[zeitlinger]

Locked Conda installs bypass the checksum-pinned download cache even when the package SHA256 is already known. I pass that checksum to the shared downloader so locked installs can reuse cached archives while retaining Conda's checksum verification.

The regression clears the Conda archive store and makes the mirror unavailable; it fails with the old call and passes with this change. Workspace Clippy, formatting, ShellCheck, and the focused e2e pass.

AI-assisted — Tool: Codex; model: openai/gpt-6-luna; version: unavailable.

Summary by CodeRabbit

• Bug Fixes
  • Improved Conda package download handling with checksum verification and support for configured download caching and mirrors.
  • Locked installations can continue using an already-installed package when the mirror is unavailable.
• Tests
  • Expanded coverage for cached downloads, mirror usage, and running installed commands during mirror outages.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Source mode: Auto
• Repository: jdx/mise
• Branch: main
• File: .coderabbit.yaml
• Commit: b04161a
• Layers: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
• Review profile: CHILL
• Plan: Advanced
• Run ID: 5e91235b-34a3-4304-93c3-e53eccee3ffd

📥 Commits

Reviewing files that changed from the base of the PR and between b04161a and 7cccfdb.

📒 Files selected for processing: 2

• e2e/backend/test_conda_url_replacements
• src/backend/conda.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

The Conda backend now downloads package archives with a pinned HTTP call. The URL replacement end-to-end test enables download caching and checks mirror downloads and an install when the mirror is unavailable.

Changes: Conda download caching

Layer / File(s)	Summary
Pinned Conda download src/backend/conda.rs	download_to now calls HTTP.download_file_pinned with the expected checksum and no additional pin. Existing checksum verification and error handling remain unchanged.
Download cache checks e2e/backend/test_conda_url_replacements	The test enables download caching, checks a locked install with caching disabled and a mirror request, then clears the Conda package store and checks that the installed command runs with the mirror unavailable.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix

Suggested reviewers: marukome0743

Merge Risk: ⚪ Minimal · up to 20df9

Merge Risk: ⚪ Minimal · up to 20df9

The cache reuse change is contract-compatible and the supplied test covers the unavailable-mirror scenario. No merge-blocking risk is established.

Pre-merge checks: 5

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: reusing cached Conda downloads during locked installs.
Docstring Coverage		Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 …
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

Full details: Docstring Coverage

Explanation

Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 1 files. (1 skipped: 1 unsupported.)

✨ Finishing Touches: 💡 1

🛠️ Fix failing CI checks: 💡

• Commit to this branch
• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Conda downloads now pass the known checksum to the shared downloader so locked installs can reuse cached archives.

• Locked Conda installs can reuse checksum-pinned cached archives.

_{Reviews (2) · Last reviewed commit: "chore: retry CI for conda cache fix" · Reviewed by Greptile}