Repository navigation
Fix Windows dev tooling failures and DEP0190 spawn warnings - #4400
Merged
Jason Morse (JasonVMo) merged 1 commit intoOct 28, 2026
Merged
Jason Morse (JasonVMo) merged 1 commit into
Jason Morse (JasonVMo) merged 1 commit into
Conversation
Launch Windows command shims through cross-spawn instead of shell-backed spawn in scripts, desktop-test, and Lage's script runner (via a Yarn patch). Preserve source line endings in codemod output so codemod tests pass on Windows. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 28a50096-95f4-4c6d-a164-944f2784e51a
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
Jason Morse (JasonVMo)
enabled auto-merge (squash)
October 28, 2026 16:34
Vladimir Morozov (vmoroz)
approved these changes
Oct 28, 2026
This was referenced Oct 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platforms Impacted
Description of changes
Fixes Windows-only dev tooling failures and Node's DEP0190 warnings about passing arguments to
spawnwithshell: true.packages/codemods:button-v0-to-v1anddeprecate-exportskeep the source file's line endings instead of using the host default (CRLF on Windows), which caused the persistent Windowsbuildcitest failure.scripts/src/utils/runScript.tsandscripts/src/tasks/checkPackageContentsTask.ts: launch commands throughcross-spawninstead of shell-backed spawn; spawn errors now reject instead of being dropped. AddsrunScript.test.ts.packages/agentic/desktop-test/src/commands.ts: launch Windows command shims (.cmd/.bat) throughcross-spawnso arguments stay escaped withoutshell: true.NpmScriptRunnerusedshell: trueon Windows; a Yarn patch (.yarn/patches/lage-npm-2.14.19-*.patch) switches it tocross-spawn, with a matching.yarnrc.ymlpackage extension. The patch must be updated or removed when Lage is upgraded.references/agents/repository/development.mdand desktop-testreferences/lifecycle.md. Changesets for codemods and desktop-test.Verification
On Windows:
yarn testinscripts: passed (56/56).yarn clean-lage-cachethenyarn lage buildciwithNODE_OPTIONS=--throw-deprecation: passed (176 tasks, 0 failed); noDEP0190or other deprecation warnings in the log.yarn change:check: passed.buildcifails in codemod tests; many DEP0190 spawn warningsbuildcipasses with no deprecation warningsPull request checklist
This PR has considered (when applicable):