Skip to content

Agentic Menu: extend contract regression coverage - #4417

Merged
Jason Morse (JasonVMo) merged 1 commit into
mainfrom
user/sriramas/menu-spec-tests
Oct 29, 2026
Merged

Jason Morse (JasonVMo) merged 1 commit into
mainfrom
user/sriramas/menu-spec-tests

Conversation

@srividyaramas

Copy link
Copy Markdown
Contributor

Why

Adds regression tests for delayed submenu hover changes, cancellation during teardown, and the supported nesting limit. This is coverage-only work, separate from the MenuButton and MenuItem product fixes.

Testing

  • Adds 6 unit regression cases; the owning components-package unit suite and existing snapshots passed in the recorded local run.
  • Package build, lint, formatting, Storybook type-checking, and component contract checks passed in the recorded local validation.
  • No new native Storybook callbacks; unit-test results are not native-host qualification.

These are local results from the unchanged, tested coverage commit. CI against current main is still required; no all-platform or overall readiness claim is made. The Windows tooling repair landed separately in #4400 and is not included in this PR.

Exercise MNU-007 two-level nesting and sibling exclusivity plus MNU-008 close-delay boundaries and cancellation of the actual scheduled timer.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
@github-actions

Copy link
Copy Markdown
Contributor

Bundle size report

Tree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.

Scenario Modules-Mac (Δ) Modules-Win (Δ) Size-Mac (Δ) Size-Win (Δ)
components-button 64 (+0) 65 (+0) 50.63k (+0b) 50.55k (+0b)
components-catalog 214 (+0) 215 (+0) 205.49k (+0b) 205.41k (+0b)
design-theme-state 34 (+0) 35 (+0) 30.15k (+0b) 30.08k (+0b)
design-themed-root 38 (+0) 39 (+0) 32.12k (+0b) 32.04k (+0b)
design-color-lib 6 (+0) 6 (+0) 6.33k (+0b) 6.33k (+0b)
design-theme-state-legacy-source 35 (+0) 36 (+0) 31.81k (+0b) 31.73k (+0b)
design-legacy-theme-from-flex 58 (+0) 59 (+0) 97.77k (+0b) 97.63k (+0b)

The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail.


View bundle-size workflow run

@JasonVMo
Jason Morse (JasonVMo) merged commit 80310a6 into main Oct 29, 2026
18 checks passed
@JasonVMo
Jason Morse (JasonVMo) deleted the user/sriramas/menu-spec-tests branch October 29, 2026 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants