Repository navigation
Agentic MenuItem: expose selection state and actions for indicator rows - #4407
Merged
Jason Morse (JasonVMo) merged 1 commit intoOct 29, 2026
Merged
Conversation
Declare resolved Toggle/Select actions and preserve caller-owned state, original events, labels and native roles. Add focused unit and Win32 native regressions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
srividyaramas
marked this pull request as ready for review
October 28, 2026 18:33
Contributor
Author
|
@microsoft-github-policy-service rerun |
Contributor
Author
|
@microsoft-github-policy-service agree company="Microsoft" |
srividyaramas
requested review from
Jason Morse (JasonVMo),
Khalef Hosany (Khalef1) and
Anandraj (mganandraj)
October 28, 2026 22:07
Jason Morse (JasonVMo)
approved these changes
Oct 29, 2026
Jason Morse (JasonVMo)
deleted the
user/sriramas/menu-item-accessibility-fix
branch
October 29, 2026 19:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Selectable agentic menu rows should expose both their current state and the action available to assistive technology. Checkbox-style and single-choice rows were not declaring all of the native selection actions needed by the Win32 accessibility interface.
What changed
Interactive indicator rows now expose checked state and a native toggle action. Single-choice rows also expose selected state and the native selection action. Ordinary command rows and headers do not gain indicator actions.
The app still owns selection. Caller action labels and unrelated actions are preserved, and the original event is forwarded without an extra press or an automatic state change. Existing menu and focus handlers are unchanged.
This change includes focused regression tests, updated component documentation, and a patch changeset. Broader component coverage will come separately.
Testing
Two existing input-dependent native cases were skipped. The disabled-action assertion checks rejection by the public driver; it does not force native dispatch to a disabled row. Other native hosts and complete keyboard/pointer behavior remain unverified.
These are local results from this product branch. CI against current main and cross-platform native results still need review. The separate Windows tooling repair landed upstream in #4400 and is not part of this change.