Repository navigation
Agentic Radio: expose selected state and the native selection action - #4406
Merged
Jason Morse (JasonVMo) merged 1 commit intoOct 29, 2026
Merged
Conversation
Preserve externally owned state and original accessibility events. Use UI Automation RadioButton SelectionItem state, not an inappropriate Toggle pattern, and add runtime/native regressions. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
srividyaramas
marked this pull request as ready for review
October 28, 2026 18:33
srividyaramas
requested review from
Jason Morse (JasonVMo),
Khalef Hosany (Khalef1) and
Anandraj (mganandraj)
October 28, 2026 22:07
Jason Morse (JasonVMo)
approved these changes
Oct 29, 2026
Jason Morse (JasonVMo)
deleted the
user/sriramas/radio-accessibility-fix
branch
October 29, 2026 19:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Agentic Radio needs to expose its current selection and the native action for selecting it. Checked state alone was not enough for the Win32 selection interface exercised by these tests.
What changed
Radio now exposes selected state alongside checked state and declares the native selection action through the shared platform resolver. It keeps its existing radio role, accessible naming, disabled behavior, and focus rules.
The app still owns selection. The original accessibility event is forwarded without selecting the radio automatically or generating a separate press.
This change includes focused regression tests, updated component documentation, and a patch changeset. Broader component coverage will come separately.
Testing
The Win32 action checks are deliberately host-specific. They do not establish native behavior on macOS or Windows Fabric, or complete keyboard/pointer coverage.
These are local results from this product branch. CI against current main and cross-platform native results still need review. The separate Windows tooling repair landed upstream in #4400 and is not part of this change.