Repository navigation
Agentic MenuButton: use visible content as the accessible name - #4405
Merged
Jason Morse (JasonVMo) merged 1 commit intoOct 29, 2026
Merged
Conversation
Project plain string, numeric and content-slot labels onto the actual native trigger, without overriding explicit accessibility names or references. Preserve menu-label derivation and cover caller renaming, native semantics and naming precedence. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 4b66f3ef-85ac-4405-bd35-dcc167a077b1
Contributor
Bundle size reportTree-shaken, minified production esbuild bundles with React and React Native runtimes externalized.
The job is advisory: size changes are reported but do not fail the pull request. Bundle or analysis errors still fail. |
srividyaramas
marked this pull request as ready for review
October 28, 2026 18:33
srividyaramas
requested review from
Jason Morse (JasonVMo),
Khalef Hosany (Khalef1) and
Anandraj (mganandraj)
October 28, 2026 22:07
Jason Morse (JasonVMo)
approved these changes
Oct 29, 2026
Jason Morse (JasonVMo)
deleted the
user/sriramas/menu-button-accessibility-fix
branch
October 29, 2026 19:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
An agentic MenuButton should have a useful accessible name when its visible label is a number or plain text supplied through the content slot. The existing fallback handled string labels, but did not cover these other supported content forms consistently.
What changed
MenuButton now derives the native trigger name from string, numeric, or plain content-slot text when the app has not provided a name. Explicit accessibility names and label references continue to take precedence.
This is a naming correction, not a change to menu opening, selection, or focus behavior. It includes focused regression tests, updated component documentation, and a patch changeset. Broader component coverage will come separately.
Testing
Four existing input-dependent native cases were skipped in the input-disabled run. This does not establish keyboard/pointer coverage or native qualification on other hosts.
These are local results from this product branch. CI against current main and cross-platform native results still need review. The separate Windows tooling repair landed upstream in #4400 and is not part of this change.