[jdx]

https://entire.io/gh/jdx/mise/trails/668

On Windows, the built-in tool-update service opened a terminal window that stayed on screen, and closing it stopped the updater. The Scheduled Task runs mise.exe __tool-update --watch, which was never classified as unattended, so it kept the console Windows hands a task's console program.

[bootstrap.services.mise-tool-update]
builtin = "tool-update"

tool-update --watch is now treated like the dotfiles watcher, so its console is hidden right after parsing. mise tool-update <tool> still keeps its console so errors can be shown.

I only verified the classification on Linux (extended only_a_starting_watcher_runs_unattended); I haven't confirmed the window disappears on Windows 11. Discussion #13426 reports the history watcher still showing a window on build 26200.9457, so that may need separate work.

Fixes #14313

AI-assisted — Tool: Claude Code; model: anthropic/claude-sonnet-5-5; version: 2.1.295.

🤖 Generated with Claude Code

---

Note

Low Risk
Small CLI classification change on Windows console behavior; interactive tool-update and non-watch paths are explicitly excluded by tests.

Overview
On Windows, the mise __tool-update --watch bootstrap/Scheduled Task path is now classified as unattended, so the CLI hides its console right after parse (same policy as the dotfiles watcher and bootstrap service launcher). That stops the updater window from staying on screen and from being closed in a way that kills the service.

ToolUpdate::is_watch() exposes whether --watch is set, and Commands::runs_unattended delegates to it. Interactive __tool-update <tool> invocations are unchanged and still keep a console for errors. Tests lock in that only --watch is unattended.

^{Reviewed by Cursor Bugbot for commit 6487ecb. Bugbot is set up for automated code reviews on this repo. Configure here.}

Summary by CodeRabbit

• Bug Fixes
  • Tool updates started in watch mode are now treated as unattended; regular tool updates remain interactive.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
• Review profile: CHILL
• Plan: Advanced
• Run ID: f174a95b-c00f-4d0d-a560-a7b64f9f8a59

📥 Commits

Reviewing files that changed from the base of the PR and between 623b640 and 6487ecb.

📒 Files selected for processing (2)

• src/cli/mod.rs
• src/cli/tool_update.rs

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.

📝 Walkthrough

Walkthrough

Watched ToolUpdate commands are now classified as unattended. The test covers both __tool-update --watch and __tool-update node.

Changes

Tool-update unattended classification

Layer / File(s)	Summary
Watch-mode classification and coverage src/cli/tool_update.rs, src/cli/mod.rs	ToolUpdate::is_watch returns the watch setting. runs_unattended uses it to classify tool-update commands. The test checks that watch mode is unattended and a non-watch command is not.

Priority: ➖ Normal

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Bug fix · Severity of issue fixed: Medium

Suggested reviewers: jambalaya56562

Merge Risk: ⚪ Minimal · up to 6487e

No actionable issue remains in the reviewed change. Windows 11 Scheduled Task console behavior still needs validation.

Pre-merge checks · 5

Passed checks (5 passed)

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly describes the main change: hiding the Windows console for the unattended tool-update service.
Linked Issues check		Issue #14313 requires the Windows tool-update service action, mise.exe __tool-update --watch, to run unattended. Commands::runs_unattended now delegates ToolUpdate classification to `ToolUpdat…
Out of Scope Changes check		The pull request changes only unattended classification, the ToolUpdate::is_watch() helper, and focused tests. These changes support issue #14313. The history watcher is not changed, which matches t…
Docstring Coverage		Docstring coverage is 80.00% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 5 functions across 2 files.

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

[Medium impact] The PR appears safe to merge; no actionable issues were found.

Summary

Treats __tool-update --watch as unattended so the Windows updater service uses the existing console-hiding path.

• The tool-update watcher now uses the unattended console path.

_{Reviews (1) · Last reviewed commit: "fix(task): hide the Windows console for ..." · Reviewed by Greptile}