[itskyf]

Summary

On Linux, brew:chafa could install successfully through mise bootstrap packages but fail at runtime with libbz2.so.1.0: cannot open shared object file.

FreeType declares uses_from_macos "bzip2" in Homebrew's formula metadata. Homebrew requires that formula on Linux, but mise's bottle dependency resolver did not include uses_from_macos in its dependency closure.

This change resolves those dependencies on Linux, including transitive dependencies and per-bottle platform variations. It excludes optional and test-only dependencies, installs build-only dependencies for source builds, and shares the dependency selection logic with the source-build environment. macOS behavior is unchanged.

Verification

Validated in a Fedora Podman container as a non-root user:

• cargo fmt --all -- --check — passed
• cargo test --all-features — passed
• cargo clippy --workspace --all-features --all-targets -- -D warnings — passed
• Fresh mise bootstrap packages apply brew:chafa — passed; brew:bzip2 was installed automatically
• chafa --version and ANSI rendering of an image downloaded from an online URL — passed

Regression tests cover metadata variations, runtime/build/test/optional dependency tags, Linux bottle installation dependencies, and source-build dependencies.

AI-assisted — Tool: ChatGPT; model: openai/GPT-6; version: unavailable.

Summary by CodeRabbit

• New Features
  • Linux package installs now include runtime dependencies listed for macOS. Source builds also include dependencies marked for building; bottle installs do not.
  • Dependency lists can vary by bottle tag, with variation-specific lists taking precedence over formula-level lists. Tagged dependencies are included according to their runtime or build classification.
• Bug Fixes
  • Build environment dependency discovery now follows the full install dependency set, including each dependency’s runtime requirements.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

• Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
• Review profile: CHILL
• Plan: Advanced
• Run ID: 08c4a24a-2424-43c6-ac1f-30e962e28266

---

📥 Commits

Reviewing files that changed from the base of the PR and between a3f4be0 and 393774a.

---

📒 Files selected for processing (1)

• crates/mise-brew-metadata/src/lib.rs

---

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

---

---

📝 Walkthrough

Walkthrough

Homebrew metadata now parses uses_from_macos dependencies and tag-specific overrides. Linux install resolution includes eligible runtime dependencies, and Linux source builds also include eligible build dependencies. Source-build dependency traversal starts from install_deps and follows each dependency’s runtime_deps.

Changes

Homebrew macOS dependency resolution

Layer / File(s)	Summary
Parse and select macOS dependencies crates/mise-brew-metadata/src/lib.rs	Formula metadata and bottle-tag variations parse uses_from_macos entries as names or tagged mappings. The metadata classifies runtime and build names and selects a tag-specific override when present. Tests cover parsing and selection.
Select install dependencies src/system/packages/brew/resolve.rs	Linux runtime dependency selection includes eligible uses_from_macos entries. Linux source installs also include eligible build entries, while bottle installs omit them. Tests cover bottle and source-build selection.
Traverse source-build dependencies src/system/packages/brew/source.rs	Source-build traversal starts from install_deps and follows each dependency’s runtime_deps. The test formula fixture initializes uses_from_macos.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Bug fix

Sequence Diagram(s)

sequenceDiagram
  participant FormulaMetadata
  participant BrewResolver
  participant SourceBuilder
  FormulaMetadata->>BrewResolver: Provide selected formula and uses_from_macos dependencies
  BrewResolver->>BrewResolver: Select runtime dependencies and source-build dependencies
  BrewResolver->>SourceBuilder: Provide install_deps
  SourceBuilder->>BrewResolver: Request runtime_deps for each dependency

Loading

Suggested reviewers: jdx

---

Merge Risk: ⚪ Minimal · up to 39377

No actionable merge-blocking risk is identified; the change is mergeable after normal checks.

Pre-merge checks | 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check		Check skipped - CodeRabbit’s high-level summary is enabled.
Title check		The title clearly and concisely describes the main change: installing Homebrew uses_from_macos dependencies on Linux.
Docstring Coverage		Docstring coverage is 94.44% which is sufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 18 functions across 3 files.
Linked Issues check		Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check		Check skipped because no linked issues were found for this pull request.

---

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

---

_{Comment @coderabbitai help to get the list of available commands.}