Repository navigation
memory: removed hp buffer heap - #1567
Conversation
There was a problem hiding this comment.
It is full bank size - aligment is easier.
There was a problem hiding this comment.
Why did it change from 0 to 0xBExxxxxx ?
There was a problem hiding this comment.
Because 0 is not realy a valid adress for a bootloader base.
Since HP heap is deleted and its base was used by bootloader as a stack we had to come up with a different place to store it. Hence the calculation.
abonislawski
left a comment
abonislawski
left a comment
There was a problem hiding this comment.
HEAP_BUFFER_SIZE not increased in APL?
dabekjakub
changed the title
720e196 to
67c7481
Compare
|
@lgirdwood @xiulipan could you help me pinpoint the issue with quemu here ?i tryed booting up this fw on my boba platform and it works. |
|
@xiulipan the qemu APL log is sending the FW ready message so not sure why its failing ? |
|
@dabekjakub |
92bc16a to
bd21156
Compare
|
@dabekjakub UT are failing. |
dabekjakub
changed the title
|
@dabekjakub what is the status now ? I have a PR to unify the memory allocation and the PR is linked to your PR. |
|
@dabekjakub ping, can you give us an ETA ? |
|
@RanderWang @lgirdwood Actualy before this removal can be implemented memory alignment feature (that i just finished working on ) must be made. |
|
#1694 Is the PR that has to come first so the DMA buffer will align correctly |
|
@dabekjakub can you fix conflicts and then @mengdonglin can schedule someone to test. |
|
@lgirdwood @mengdonglin It could use a round of back to back testing , since the buffer pointers were moved (the alignment commit should have fixed that, however, it is good to be sure). |
|
SOFCI TEST |
|
@jajanusz do You think that the
should stay in buffer.h or should it be platform-specific in memory.h? |
cdb3374 to
b007236
Compare
Merged hp buffer heap with normal buffer heap. Since current buffer heap was actually using hp memory and it served no purpose to have two heaps. Removed extern capabilities and merged other capabiliteis to buffer heap. Currently none of those buffer heaps supports extern. Signed-off-by: Jakub Dabek <jakub.dabek@intel.com>
Add seeting of alignment for DMA buffer that is required by Hardware configuration. Signed-off-by: Jakub Dabek <jakub.dabek@intel.com>
Merged hp buffer heap with normal buffer heap.
Since current buffer heap was actualy using hp memory and it served
no purpose to have two heaps.
Removed extern capabilities and merged other capabiliteis to
buffer heap. Currently none of those buffer heaps supports extern.
Signed-off-by: Jakub Dabek jakub.dabek@intel.com