Repository navigation
memory: added requesting alignment for buffer heap - #1694
Closed
dabekjakub wants to merge 1 commit into
Closed
dabekjakub wants to merge 1 commit into
dabekjakub wants to merge 1 commit into
Conversation
dabekjakub
requested review from
abonislawski,
akloniex,
dbaluta,
jajanusz and
tlauda
July 31, 2019 12:45
dabekjakub
requested review from
lbetlej,
lgirdwood,
libinyang,
mmaka1 and
plbossart
as code owners
July 31, 2019 12:45
dbaluta
reviewed
Jul 31, 2019
dbaluta
reviewed
Jul 31, 2019
dbaluta
reviewed
Jul 31, 2019
dbaluta
reviewed
Jul 31, 2019
dbaluta
reviewed
Jul 31, 2019
Collaborator
There was a problem hiding this comment.
The commit message is empty? Please give more information about why this change is needed. Also please use imperative mood as pointed out in a previous comment.
So, please use something like this:
memory: Introduce API for requesting align buffers
This is needed because....
I am pretty sure everything is clear for you because you worked on that. But please have mercy on some poor
guys wanting to understand the code on months later.
jajanusz
suggested changes
Jul 31, 2019
Contributor
|
@dabekjakub Please fix also checkpatch warnings - except |
tlauda
suggested changes
Aug 1, 2019
tlauda
reviewed
Aug 1, 2019
Contributor
There was a problem hiding this comment.
Default alignment should be cache line size. It will be due to the buffer placement, but it's always better to show it explicitly.
mrajwa
reviewed
Aug 1, 2019
dabekjakub
force-pushed
the
alignment
branch
2 times, most recently
from
August 1, 2019 12:44
736949f to
9ef1b43
Compare
Added buffer alignment API. Needed to set alignment that different buffers require. Example: Dma buffer has to be aligned to 128 due to hardware configuration. Signed-off-by: Jakub Dabek <jakub.dabek@intel.com>
jajanusz
reviewed
Aug 1, 2019
Member
Author
Member
Author
|
Droping this for new version in #1698 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some buffers need to be aligned - added this possibility.
Introduced wa for dma buffer alignment. Until now
buffers were aligned because buffer heap started aligned and
buffer blocks were in alignmet with dma required alignment - 128.
Introduced WA for DMA buffers which need to be changed to
topology token.
Signed-off-by: Jakub Dabek jakub.dabek@intel.com