Repository navigation
Sue Creek SSP clock fix and a cosmetic patch - #1583
Merged
Merged
Conversation
Commit f5e7843 ("cavs: ssp: generic ssp mclk configuration for cavs" made Sue Creek unstable, IPC communication with it would often fail. The reason for this is, that the Sue Creek uses the SSP clock as its platform clock. This patch restores the original values. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Firstly, it is better to rely on the compiler to decide which functions to inline, except in some special cases. Secondly, functions called by reference, cannot be inlined. This patch removes "inline" from functions used as .set_config() methods. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
lyakh
requested review from
RanderWang,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
June 20, 2019 13:06
lgirdwood
approved these changes
Jun 23, 2019
tlauda
approved these changes
Jun 24, 2019
Collaborator
Author
|
There's still an authentication error in CI... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first patch in the series fixes the second regression in #1575 on Sue Creek, which makes it unstable. This alone, however, doesn't fix Sue Creek completely. As described in #1575 there's also another regression, which breaks booting on Sue Creek. Reverting #1483 isn't any longer possible, #1567 doesn't apply any more either.