Skip to content

Ensure iterators convert to const iterators - #1264

Merged
Carson Radtke (carsonRadtke) merged 2 commits into
microsoft:mainfrom
carsonRadtke:carsonradtke/const-iterator-conversions
Aug 25, 2026
Merged

Carson Radtke (carsonRadtke) merged 2 commits into
microsoft:mainfrom
carsonRadtke:carsonradtke/const-iterator-conversions

Conversation

@carsonRadtke

Copy link
Copy Markdown
Member

Summary

  • add compile-time assertions for implicit iterator-to-const-iterator conversion in dyn_array and span
  • add the missing implicit conversion to dyn_array_iterator

Testing

  • MSVC C++14: dyn_array_tests, span_compatibility_tests
  • MSVC C++20: dyn_array_tests, span_compatibility_tests

Add compile-time coverage for dyn_array and span iterator conversions, and implement the missing dyn_array conversion.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@carsonRadtke
Carson Radtke (carsonRadtke) merged commit b4fa05c into microsoft:main Aug 25, 2026
87 checks passed
Carson Radtke (carsonRadtke) added a commit that referenced this pull request Aug 25, 2026
* Ensure iterators convert to const iterators

Add compile-time coverage for dyn_array and span iterator conversions, and implement the missing dyn_array conversion.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Format const iterator changes

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
social4hyq pushed a commit to social4hyq/homebrew-core that referenced this pull request Sep 20, 2026
cpp-gsl 5.0.0

Created-by: HarmonybrewBot
Commit-by: HarmonybrewBot
Merged-by: HarmonybrewBot
Description: Created by `brew bump`

---

Created with `brew bump-formula-pr`.<details>
  <summary>release notes</summary>
  <pre>## What's Changed
* Update return by value threshold in gsl::not_null by @ozaktash in microsoft/GSL#1205
* copilot: Provide more project context for the Copilot coding agent by @carsonRadtke in microsoft/GSL#1207
* Document differences between hardened std::span and gsl::span by @carsonRadtke with @Copilot in microsoft/GSL#1206
* Add constexpr to not_null comparison operators by @carsonRadtke with @Copilot in microsoft/GSL#1208
* fix: all pipeline failures by @carsonRadtke in microsoft/GSL#1221
* export proper syntax for GSL_SUPPRESS for new VS by @carsonRadtke in microsoft/GSL#1213
* Revert unintended change to GSL_SUPPRESS by @beinhaerter in microsoft/GSL#1226
* use cmake presets instead of cmake settings by @carsonRadtke in microsoft/GSL#1219
* Fix std::hash compilation error for gsl::not_null<std::shared_ptr<T>> by @carsonRadtke with @Copilot in microsoft/GSL#1210
* infra: individual test executables by @carsonRadtke in microsoft/GSL#1212
* doc: Update URL in pointers to F.16 C++ Core Guidelines by @maflcko in microsoft/GSL#1232
* doc: Fix to use lower-case anchors in links to C++ Core Guidelines by @maflcko in microsoft/GSL#1234
* gsl::not_null: C.85: Make swap noexcept by @maflcko in microsoft/GSL#1235
* gsl::not_null: C.89: Make a hash noexcept by @maflcko in microsoft/GSL#1236
* ci: Bump to actions/checkout@v6 by @maflcko in microsoft/GSL#1237
* ci: Use microsoft/setup-msbuild@v3 by @maflcko in microsoft/GSL#1240
* narrow_cast instead of static_cast by @beinhaerter in microsoft/GSL#1250
* ci: Bump actions/setup-java@v5 by @maflcko in microsoft/GSL#1249
* remove space in GSL_SUPPRESS by @beinhaerter in microsoft/GSL#1248
* clang-format improvements by @beinhaerter in microsoft/GSL#1251
* feat: implementation of gsl::dyn_array by @carsonRadtke in microsoft/GSL#1228
* ci: fix failing actions by @carsonRadtke in microsoft/GSL#1255
* docs: fix false statements in gsl::dyn_array docs by @carsonRadtke in microsoft/GSL#1254
* dyn_array: fix include tree by @carsonRadtke in microsoft/GSL#1261
* Bump GSL to v5.0.0 by @carsonRadtke in microsoft/GSL#1262
* docs: fix http:// to https:// in CppCoreGuidelines links by @Rajkaran-122 in microsoft/GSL#1267
* Fix floating-to-integral narrow undefined behavior by @carsonRadtke in microsoft/GSL#1266
* Ensure iterators convert to const iterators by @carsonRadtke in microsoft/GSL#1264
* Prevent external construction of checked iterators by @carsonRadtke in microsoft/GSL#1263

## New Contributors
* @ozaktash made their first contribution in microsoft/GSL#1205
* @maflcko made their first contribution in microsoft/GSL#1232
* @Rajkaran-122 made their first contribution in microsoft/GSL#1267

**Full Changelog**: https://github.com/microsoft/GSL/compare/v4.2.2...v5.0.0</pre>
  <p>View the full release notes at <a href="https://github.com/microsoft/GSL/releases/tag/v5.0.0">https://github.com/microsoft/GSL/releases/tag/v5.0.0</a>.</p>
</details>
<hr>

See merge request: Harmonybrew/homebrew-core!17783
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants