Repository navigation
use cmake presets instead of cmake settings - #1219
Merged
Carson Radtke (carsonRadtke) merged 5 commits intoDec 5, 2025
Merged
Conversation
Carson Radtke (carsonRadtke)
marked this pull request as ready for review
September 30, 2025 17:45
Carson Radtke (carsonRadtke)
added
Type: Enhancement
github-project-automation
Bot
moved this to Open
in Microsoft/GSL Pull Requests In-Flight
Carson Radtke (carsonRadtke)
moved this from Open
to Ready for Review
in Microsoft/GSL Pull Requests In-Flight
Carson Radtke (carsonRadtke)
force-pushed
the
carsonradtke/add-cmake-presets
branch
from
October 1, 2025 16:06
9cee3da to
b14edaa
Compare
Member
Author
|
Copilot Can you update the GitHub Actions to make use of the presets? |
Contributor
|
Carson Radtke (@carsonRadtke) I've opened a new pull request, #1223, to work on those changes. Once the pull request is ready, I'll request review from you. |
This change uses a cmake presets file in an effort allow for agentic AI to better switch between project settings. It replaces the old CMakeSettings.json for the more flexible CMakePresets.json.
* Initial plan * Update GitHub Actions to use CMake presets for compilers workflow Co-authored-by: carsonRadtke <10507970+carsonRadtke@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: carsonRadtke <10507970+carsonRadtke@users.noreply.github.com>
Carson Radtke (carsonRadtke)
force-pushed
the
carsonradtke/add-cmake-presets
branch
from
December 4, 2025 23:44
f67008e to
2214ecd
Compare
Carson Radtke (carsonRadtke)
added
the
Status: Review Needed
Carson Radtke (carsonRadtke)
requested review from
Copilot and
Gabriel Dos Reis (gdr-at-ms)
December 5, 2025 15:51
Contributor
There was a problem hiding this comment.
Pull request overview
This PR modernizes the build configuration by migrating from the Visual Studio-specific CMakeSettings.json to the more standardized and flexible CMakePresets.json format. This change improves cross-platform and cross-IDE support, particularly for agentic AI tooling that can now more easily switch between different build configurations.
Key Changes
- Introduces comprehensive CMakePresets.json with 24 configure presets covering all combinations of compilers (MSVC, GCC, Clang), C++ standards (14, 17, 20, 23), and build types (Debug, Release)
- Updates GitHub Actions workflows to use CMake presets instead of manual parameter passing
- Simplifies the cmake composite action by consolidating parameters into a single preset identifier
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| CMakeSettings.json | Removed legacy Visual Studio CMake settings file |
| CMakePresets.json | Added comprehensive preset definitions for all supported compiler/standard/build type combinations with proper inheritance hierarchy |
| .github/workflows/copilot-setup-steps.yml | Updated to use clang presets for C++14 and C++20 builds |
| .github/workflows/compilers.yml | Simplified workflow by replacing multiple parameters with preset names for gcc, clang, xcode, and MSVC jobs |
| .github/workflows/cmake/action.yml | Streamlined action inputs to use single preset parameter instead of multiple build configuration parameters |
Gabriel Dos Reis (gdr-at-ms)
approved these changes
Dec 5, 2025
github-project-automation
Bot
moved this from Ready for Review
to Approved
in Microsoft/GSL Pull Requests In-Flight
github-project-automation
Bot
moved this from Approved
to Merged
in Microsoft/GSL Pull Requests In-Flight
Carson Radtke (carsonRadtke)
deleted the
carsonradtke/add-cmake-presets
branch
December 8, 2025 17:41
social4hyq
pushed a commit
to social4hyq/homebrew-core
that referenced
this pull request
Sep 20, 2026
cpp-gsl 5.0.0 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre>## What's Changed * Update return by value threshold in gsl::not_null by @ozaktash in microsoft/GSL#1205 * copilot: Provide more project context for the Copilot coding agent by @carsonRadtke in microsoft/GSL#1207 * Document differences between hardened std::span and gsl::span by @carsonRadtke with @Copilot in microsoft/GSL#1206 * Add constexpr to not_null comparison operators by @carsonRadtke with @Copilot in microsoft/GSL#1208 * fix: all pipeline failures by @carsonRadtke in microsoft/GSL#1221 * export proper syntax for GSL_SUPPRESS for new VS by @carsonRadtke in microsoft/GSL#1213 * Revert unintended change to GSL_SUPPRESS by @beinhaerter in microsoft/GSL#1226 * use cmake presets instead of cmake settings by @carsonRadtke in microsoft/GSL#1219 * Fix std::hash compilation error for gsl::not_null<std::shared_ptr<T>> by @carsonRadtke with @Copilot in microsoft/GSL#1210 * infra: individual test executables by @carsonRadtke in microsoft/GSL#1212 * doc: Update URL in pointers to F.16 C++ Core Guidelines by @maflcko in microsoft/GSL#1232 * doc: Fix to use lower-case anchors in links to C++ Core Guidelines by @maflcko in microsoft/GSL#1234 * gsl::not_null: C.85: Make swap noexcept by @maflcko in microsoft/GSL#1235 * gsl::not_null: C.89: Make a hash noexcept by @maflcko in microsoft/GSL#1236 * ci: Bump to actions/checkout@v6 by @maflcko in microsoft/GSL#1237 * ci: Use microsoft/setup-msbuild@v3 by @maflcko in microsoft/GSL#1240 * narrow_cast instead of static_cast by @beinhaerter in microsoft/GSL#1250 * ci: Bump actions/setup-java@v5 by @maflcko in microsoft/GSL#1249 * remove space in GSL_SUPPRESS by @beinhaerter in microsoft/GSL#1248 * clang-format improvements by @beinhaerter in microsoft/GSL#1251 * feat: implementation of gsl::dyn_array by @carsonRadtke in microsoft/GSL#1228 * ci: fix failing actions by @carsonRadtke in microsoft/GSL#1255 * docs: fix false statements in gsl::dyn_array docs by @carsonRadtke in microsoft/GSL#1254 * dyn_array: fix include tree by @carsonRadtke in microsoft/GSL#1261 * Bump GSL to v5.0.0 by @carsonRadtke in microsoft/GSL#1262 * docs: fix http:// to https:// in CppCoreGuidelines links by @Rajkaran-122 in microsoft/GSL#1267 * Fix floating-to-integral narrow undefined behavior by @carsonRadtke in microsoft/GSL#1266 * Ensure iterators convert to const iterators by @carsonRadtke in microsoft/GSL#1264 * Prevent external construction of checked iterators by @carsonRadtke in microsoft/GSL#1263 ## New Contributors * @ozaktash made their first contribution in microsoft/GSL#1205 * @maflcko made their first contribution in microsoft/GSL#1232 * @Rajkaran-122 made their first contribution in microsoft/GSL#1267 **Full Changelog**: https://github.com/microsoft/GSL/compare/v4.2.2...v5.0.0</pre> <p>View the full release notes at <a href="https://github.com/microsoft/GSL/releases/tag/v5.0.0">https://github.com/microsoft/GSL/releases/tag/v5.0.0</a>.</p> </details> <hr> See merge request: Harmonybrew/homebrew-core!17783
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change uses a cmake presets file in an effort allow for agentic AI to better switch between project settings. It replaces the old CMakeSettings.json for the more flexible CMakePresets.json.