infra: individual test executables by carsonRadtke · Pull Request #1212 · microsoft/GSL

Carson Radtke (carsonRadtke) · 2025-08-21T16:01:51Z

We used have tests contained in a single executable. This was fine for testing, but it would be more convient to separate tests into indivudal modules so targeted changes could have targeted tests.

This change associates each test file with its own executable. We now have 14 tests for GSL each of which testing a different component.

Copilot

Pull Request Overview

This PR modernizes the GSL test infrastructure by separating tests from a single monolithic executable into individual test executables for each component. This change improves development workflow by enabling targeted testing of specific components.

Splits the single gsl_tests executable into 14 individual test executables, one per test source file
Simplifies MSVC version checks in span tests to focus on C++14 compatibility instead of specific compiler versions
Maintains the same test coverage while improving modularity and development experience

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File	Description
tests/CMakeLists.txt	Refactors build system to create individual executables for each test source file using a foreach loop
tests/span_tests.cpp	Simplifies MSVC version checks by removing specific version numbers and focusing on C++14 standard

We used have tests contained in a single executable. This was fine for testing, but it would be more convient to separate tests into indivudal modules so targeted changes could have targeted tests. This change associates each test file with its own executable. We now have 14 tests for GSL each of which testing a different component.

thanks copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.

Copilot · 2025-12-05T17:50:39Z

Carson Radtke (@carsonRadtke) I've opened a new pull request, #1227, to work on those changes. Once the pull request is ready, I'll request review from you.

* Initial plan * Use file globbing for test sources instead of manual list Replace the manually maintained list of test sources with file(GLOB) to automatically discover all .cpp files in the tests directory, excluding no_exception_ensure_tests.cpp which needs special compilation flags. This approach: - Automatically picks up new test files without CMake updates - Still correctly excludes no_exception_ensure_tests.cpp - Maintains the same test build configuration - Works with both C++14 and C++20 Co-authored-by: carsonRadtke <10507970+carsonRadtke@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: carsonRadtke <10507970+carsonRadtke@users.noreply.github.com>

@ozaktash

cpp-gsl 5.0.0 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre>## What's Changed * Update return by value threshold in gsl::not_null by @ozaktash in microsoft/GSL#1205 * copilot: Provide more project context for the Copilot coding agent by @carsonRadtke in microsoft/GSL#1207 * Document differences between hardened std::span and gsl::span by @carsonRadtke with @Copilot in microsoft/GSL#1206 * Add constexpr to not_null comparison operators by @carsonRadtke with @Copilot in microsoft/GSL#1208 * fix: all pipeline failures by @carsonRadtke in microsoft/GSL#1221 * export proper syntax for GSL_SUPPRESS for new VS by @carsonRadtke in microsoft/GSL#1213 * Revert unintended change to GSL_SUPPRESS by @beinhaerter in microsoft/GSL#1226 * use cmake presets instead of cmake settings by @carsonRadtke in microsoft/GSL#1219 * Fix std::hash compilation error for gsl::not_null<std::shared_ptr<T>> by @carsonRadtke with @Copilot in microsoft/GSL#1210 * infra: individual test executables by @carsonRadtke in microsoft/GSL#1212 * doc: Update URL in pointers to F.16 C++ Core Guidelines by @maflcko in microsoft/GSL#1232 * doc: Fix to use lower-case anchors in links to C++ Core Guidelines by @maflcko in microsoft/GSL#1234 * gsl::not_null: C.85: Make swap noexcept by @maflcko in microsoft/GSL#1235 * gsl::not_null: C.89: Make a hash noexcept by @maflcko in microsoft/GSL#1236 * ci: Bump to actions/checkout@v6 by @maflcko in microsoft/GSL#1237 * ci: Use microsoft/setup-msbuild@v3 by @maflcko in microsoft/GSL#1240 * narrow_cast instead of static_cast by @beinhaerter in microsoft/GSL#1250 * ci: Bump actions/setup-java@v5 by @maflcko in microsoft/GSL#1249 * remove space in GSL_SUPPRESS by @beinhaerter in microsoft/GSL#1248 * clang-format improvements by @beinhaerter in microsoft/GSL#1251 * feat: implementation of gsl::dyn_array by @carsonRadtke in microsoft/GSL#1228 * ci: fix failing actions by @carsonRadtke in microsoft/GSL#1255 * docs: fix false statements in gsl::dyn_array docs by @carsonRadtke in microsoft/GSL#1254 * dyn_array: fix include tree by @carsonRadtke in microsoft/GSL#1261 * Bump GSL to v5.0.0 by @carsonRadtke in microsoft/GSL#1262 * docs: fix http:// to https:// in CppCoreGuidelines links by @Rajkaran-122 in microsoft/GSL#1267 * Fix floating-to-integral narrow undefined behavior by @carsonRadtke in microsoft/GSL#1266 * Ensure iterators convert to const iterators by @carsonRadtke in microsoft/GSL#1264 * Prevent external construction of checked iterators by @carsonRadtke in microsoft/GSL#1263 ## New Contributors * @ozaktash made their first contribution in microsoft/GSL#1205 * @maflcko made their first contribution in microsoft/GSL#1232 * @Rajkaran-122 made their first contribution in microsoft/GSL#1267 **Full Changelog**: https://github.com/microsoft/GSL/compare/v4.2.2...v5.0.0</pre> <p>View the full release notes at <a href="https://github.com/microsoft/GSL/releases/tag/v5.0.0">https://github.com/microsoft/GSL/releases/tag/v5.0.0</a>.</p> </details> <hr> See merge request: Harmonybrew/homebrew-core!17783

Carson Radtke (carsonRadtke) requested a review from Copilot August 21, 2025 16:12

Carson Radtke (carsonRadtke) self-assigned this Aug 21, 2025

Copilot AI reviewed Aug 21, 2025

View reviewed changes

Comment thread tests/span_tests.cpp Resolved

Carson Radtke (carsonRadtke) added Type: Infra Changes to build system, tests, or pipelines Status: In Progress Currently being worked on labels Aug 21, 2025

Carson Radtke (carsonRadtke) added this to Microsoft/GSL Pull Requests In-Flight Sep 30, 2025

Carson Radtke (carsonRadtke) moved this to Ready for Review in Microsoft/GSL Pull Requests In-Flight Sep 30, 2025

Carson Radtke (carsonRadtke) force-pushed the carsonradtke/individual-tests branch from dbcffab to 1bb885c Compare October 1, 2025 16:05

Carson Radtke (carsonRadtke) and others added 3 commits December 4, 2025 14:38

revert -Wno-reserved-identifier

c4b08fd

Update tests/span_tests.cpp

731955d

thanks copilot Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Carson Radtke (carsonRadtke) force-pushed the carsonradtke/individual-tests branch from 1bb885c to 731955d Compare December 4, 2025 21:38

Carson Radtke (carsonRadtke) added 2 commits December 4, 2025 14:45

be sure to include build type in ctest command

7213c4f

[VS] make sure we are building the correct configuration

f8070f0

Carson Radtke (carsonRadtke) added Status: Review Needed Needs review from GSL maintainers and removed Status: In Progress Currently being worked on labels Dec 4, 2025

restore tests/span_tests.cpp

ad25246

Carson Radtke (carsonRadtke) requested review from Copilot and Gabriel Dos Reis (gdr-at-ms) December 5, 2025 15:51

Copilot started reviewing on behalf of Carson Radtke (carsonRadtke) December 5, 2025 15:52

View session

Copilot finished reviewing on behalf of Carson Radtke (carsonRadtke) December 5, 2025 15:54

Copilot AI reviewed Dec 5, 2025

View reviewed changes

Gabriel Dos Reis (gdr-at-ms) approved these changes Dec 5, 2025

View reviewed changes

github-project-automation Bot moved this from Ready for Review to Approved in Microsoft/GSL Pull Requests In-Flight Dec 5, 2025

Carson Radtke (carsonRadtke) added 5 commits December 5, 2025 10:01

Merge branch 'main' into carsonradtke/individual-tests

2374edf

fix build break after merge conflicts

6f472c7

fix build break after merge conflicts #2

d51b779

another try at fixing a build break

69bd7d6

fix silly typo. build break pt 4

5543d70

Carson Radtke (carsonRadtke) commented Dec 5, 2025

View reviewed changes

Comment thread tests/CMakeLists.txt Resolved

Copilot AI mentioned this pull request Dec 5, 2025

Use file globbing for test sources instead of manual list #1227

Merged

Carson Radtke (carsonRadtke) requested a review from Gabriel Dos Reis (gdr-at-ms) December 5, 2025 18:16

Gabriel Dos Reis (gdr-at-ms) approved these changes Dec 5, 2025

View reviewed changes

Carson Radtke (carsonRadtke) merged commit 756c91a into main Dec 5, 2025
90 checks passed

github-project-automation Bot moved this from Approved to Merged in Microsoft/GSL Pull Requests In-Flight Dec 5, 2025

Carson Radtke (carsonRadtke) deleted the carsonradtke/individual-tests branch December 5, 2025 20:24

Navigation Menu

Repository navigation

infra: individual test executables - #1212

infra: individual test executables#1212
Carson Radtke (carsonRadtke) merged 12 commits into
mainfrom
carsonradtke/individual-tests

Carson Radtke (carsonRadtke) commented Aug 21, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Copilot AI commented Dec 5, 2025

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Carson Radtke (carsonRadtke) commented Aug 21, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI commented Dec 5, 2025

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Carson Radtke (carsonRadtke) commented Aug 21, 2025 •

edited

Loading