Fix std::hash compilation error for gsl::not_null<std::shared_ptr<T>> by Copilot · Pull Request #1210 · microsoft/GSL

Copilot · 2025-06-02T19:48:10Z

Fix std::hash compilation error for gsl::not_null with shared_ptr
Add comment explaining safe usage of typename T::element_type in not_null_hash
Rebase changes onto main to re-trigger CI tests
Remove upgrade_checklist.md file as requested

All changes have been successfully rebased onto the latest main branch and unnecessary file has been removed.

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot

Pull Request Overview

This PR fixes the compilation error related to the specialization of std::hash for gsl::not_null<std::shared_ptr> by changing the template deduction from decltype(.get()) to use typename T::element_type.

Update not_null_hash template in include/gsl/pointers to correctly deduce the type.
Add new tests in tests/notnull_tests.cpp to verify correct behavior of std::hash with not_null.
Ensure compatibility with both C++14 and C++20 standards.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
tests/notnull_tests.cpp	Added test cases to validate correct hashing behavior for not_null<std::shared_ptr>.
include/gsl/pointers	Updated the not_null_hash template to use typename T::element_type for proper type deduction.

Carson Radtke (carsonRadtke) · 2025-12-04T22:26:02Z

Copilot Can you rebase these changes onto main so the tests actions re-run?

Copilot · 2025-12-04T22:28:50Z

Copilot Can you rebase these changes onto main so the tests actions re-run?

Rebased the changes onto main in commit 9371256. The CI test actions should now re-run on the updated codebase.

Co-authored-by: carsonRadtke <10507970+carsonRadtke@users.noreply.github.com>

…null_hash Co-authored-by: carsonRadtke <10507970+carsonRadtke@users.noreply.github.com>

Co-authored-by: carsonRadtke <10507970+carsonRadtke@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

@ozaktash

cpp-gsl 5.0.0 Created-by: HarmonybrewBot Commit-by: HarmonybrewBot Merged-by: HarmonybrewBot Description: Created by `brew bump` --- Created with `brew bump-formula-pr`.<details> <summary>release notes</summary> <pre>## What's Changed * Update return by value threshold in gsl::not_null by @ozaktash in microsoft/GSL#1205 * copilot: Provide more project context for the Copilot coding agent by @carsonRadtke in microsoft/GSL#1207 * Document differences between hardened std::span and gsl::span by @carsonRadtke with @Copilot in microsoft/GSL#1206 * Add constexpr to not_null comparison operators by @carsonRadtke with @Copilot in microsoft/GSL#1208 * fix: all pipeline failures by @carsonRadtke in microsoft/GSL#1221 * export proper syntax for GSL_SUPPRESS for new VS by @carsonRadtke in microsoft/GSL#1213 * Revert unintended change to GSL_SUPPRESS by @beinhaerter in microsoft/GSL#1226 * use cmake presets instead of cmake settings by @carsonRadtke in microsoft/GSL#1219 * Fix std::hash compilation error for gsl::not_null<std::shared_ptr<T>> by @carsonRadtke with @Copilot in microsoft/GSL#1210 * infra: individual test executables by @carsonRadtke in microsoft/GSL#1212 * doc: Update URL in pointers to F.16 C++ Core Guidelines by @maflcko in microsoft/GSL#1232 * doc: Fix to use lower-case anchors in links to C++ Core Guidelines by @maflcko in microsoft/GSL#1234 * gsl::not_null: C.85: Make swap noexcept by @maflcko in microsoft/GSL#1235 * gsl::not_null: C.89: Make a hash noexcept by @maflcko in microsoft/GSL#1236 * ci: Bump to actions/checkout@v6 by @maflcko in microsoft/GSL#1237 * ci: Use microsoft/setup-msbuild@v3 by @maflcko in microsoft/GSL#1240 * narrow_cast instead of static_cast by @beinhaerter in microsoft/GSL#1250 * ci: Bump actions/setup-java@v5 by @maflcko in microsoft/GSL#1249 * remove space in GSL_SUPPRESS by @beinhaerter in microsoft/GSL#1248 * clang-format improvements by @beinhaerter in microsoft/GSL#1251 * feat: implementation of gsl::dyn_array by @carsonRadtke in microsoft/GSL#1228 * ci: fix failing actions by @carsonRadtke in microsoft/GSL#1255 * docs: fix false statements in gsl::dyn_array docs by @carsonRadtke in microsoft/GSL#1254 * dyn_array: fix include tree by @carsonRadtke in microsoft/GSL#1261 * Bump GSL to v5.0.0 by @carsonRadtke in microsoft/GSL#1262 * docs: fix http:// to https:// in CppCoreGuidelines links by @Rajkaran-122 in microsoft/GSL#1267 * Fix floating-to-integral narrow undefined behavior by @carsonRadtke in microsoft/GSL#1266 * Ensure iterators convert to const iterators by @carsonRadtke in microsoft/GSL#1264 * Prevent external construction of checked iterators by @carsonRadtke in microsoft/GSL#1263 ## New Contributors * @ozaktash made their first contribution in microsoft/GSL#1205 * @maflcko made their first contribution in microsoft/GSL#1232 * @Rajkaran-122 made their first contribution in microsoft/GSL#1267 **Full Changelog**: https://github.com/microsoft/GSL/compare/v4.2.2...v5.0.0</pre> <p>View the full release notes at <a href="https://github.com/microsoft/GSL/releases/tag/v5.0.0">https://github.com/microsoft/GSL/releases/tag/v5.0.0</a>.</p> </details> <hr> See merge request: Harmonybrew/homebrew-core!17783

Copilot AI assigned Copilot and Carson Radtke (carsonRadtke) Jun 2, 2025

Copilot started work on behalf of Carson Radtke (carsonRadtke) June 2, 2025 19:48

View session

Copilot AI changed the title ~~[WIP] Compilation error with std::hash<gsl::not_null<std::shared_ptr<T>>> in GSL 4.2.0~~ Fix std::hash compilation error for gsl::not_null<std::shared_ptr<T>> Jun 2, 2025

Copilot AI requested a review from Carson Radtke (carsonRadtke) June 2, 2025 19:56

Copilot finished work on behalf of Carson Radtke (carsonRadtke) June 2, 2025 19:56

Carson Radtke (carsonRadtke) requested a review from Copilot June 2, 2025 20:07

Copilot AI reviewed Jun 2, 2025

View reviewed changes

Carson Radtke (carsonRadtke) marked this pull request as ready for review June 3, 2025 14:35

Carson Radtke (carsonRadtke) requested changes Jul 26, 2025

View reviewed changes

Comment thread include/gsl/pointers Resolved

Copilot started work on behalf of Carson Radtke (carsonRadtke) July 26, 2025 03:06

View session

Copilot AI requested a review from Carson Radtke (carsonRadtke) July 26, 2025 03:13

Copilot finished work on behalf of Carson Radtke (carsonRadtke) July 26, 2025 03:13

Carson Radtke (carsonRadtke) approved these changes Dec 4, 2025

View reviewed changes

Copilot started work on behalf of Carson Radtke (carsonRadtke) December 4, 2025 22:26

View session

Copilot finished work on behalf of Carson Radtke (carsonRadtke) December 4, 2025 22:30

Copilot AI requested a review from Carson Radtke (carsonRadtke) December 4, 2025 22:30

Carson Radtke (carsonRadtke) requested changes Dec 4, 2025

View reviewed changes

Comment thread docs/upgrade_checklist.md Resolved

Copilot started work on behalf of Carson Radtke (carsonRadtke) December 4, 2025 22:33

View session

Copilot AI requested a review from Carson Radtke (carsonRadtke) December 4, 2025 22:37

Copilot finished work on behalf of Carson Radtke (carsonRadtke) December 4, 2025 22:37

Carson Radtke (carsonRadtke) added the Status: Review Needed Needs review from GSL maintainers label Dec 4, 2025

Carson Radtke (carsonRadtke) linked an issue Dec 4, 2025 that may be closed by this pull request

Compilation error with std::hash<gsl::not_null<std::shared_ptr<T>>> in GSL 4.2.0 #1209

Closed

Copilot AI and others added 5 commits December 5, 2025 08:46

Initial plan for issue

aa97c20

Fix hash compilation issue for gsl::not_null with shared_ptr

718bdb1

Co-authored-by: carsonRadtke <10507970+carsonRadtke@users.noreply.github.com>

Add comment explaining safe usage of typename T::element_type in not_…

3e67ae6

…null_hash Co-authored-by: carsonRadtke <10507970+carsonRadtke@users.noreply.github.com>

Initial plan for issue

a956a66

Remove upgrade_checklist.md file as requested

aea4413

Co-authored-by: carsonRadtke <10507970+carsonRadtke@users.noreply.github.com>

restore docs/upgrade_checklist.md

6b49c57

Carson Radtke (carsonRadtke) force-pushed the copilot/fix-1209 branch from 3a73cc7 to 6b49c57 Compare December 5, 2025 15:47

Carson Radtke (carsonRadtke) requested review from Copilot and Gabriel Dos Reis (gdr-at-ms) December 5, 2025 15:51

Copilot started reviewing on behalf of Carson Radtke (carsonRadtke) December 5, 2025 15:52

View session

Copilot finished reviewing on behalf of Carson Radtke (carsonRadtke) December 5, 2025 15:54

Copilot AI reviewed Dec 5, 2025

View reviewed changes

Comment thread include/gsl/pointers Resolved

Comment thread tests/notnull_tests.cpp Resolved

Gabriel Dos Reis (gdr-at-ms) approved these changes Dec 5, 2025

View reviewed changes

Carson Radtke (carsonRadtke) approved these changes Dec 5, 2025

View reviewed changes

Carson Radtke (carsonRadtke) merged commit 1883887 into main Dec 5, 2025
96 checks passed

Carson Radtke (carsonRadtke) deleted the copilot/fix-1209 branch December 8, 2025 17:41

Navigation Menu

Repository navigation

Fix std::hash compilation error for gsl::not_null<std::shared_ptr<T>> - #1210

Fix std::hash compilation error for gsl::not_null<std::shared_ptr<T>>#1210
Carson Radtke (carsonRadtke) merged 6 commits into
mainfrom
copilot/fix-1209

Copilot AI commented Jun 2, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Carson Radtke (carsonRadtke) commented Dec 4, 2025

Uh oh!

Copilot AI commented Dec 4, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Conversation

Copilot AI commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Carson Radtke (carsonRadtke) commented Dec 4, 2025

Uh oh!

Copilot AI commented Dec 4, 2025

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Copilot AI commented Jun 2, 2025 •

edited

Loading