Skip to content

Update return by value threshold in gsl::not_null - #1205

Merged
Carson Radtke (carsonRadtke) merged 1 commit into
microsoft:mainfrom
ozaktash:not-null-rbv-th
May 12, 2025
Merged

Carson Radtke (carsonRadtke) merged 1 commit into
microsoft:mainfrom
ozaktash:not-null-rbv-th

Conversation

@ozaktash

@ozaktash ozaktash commented May 4, 2025

Copy link
Copy Markdown
Contributor

Fixes: #1204

  • Allow returning by value for types that are not greater than two pointers in size

- Allow returning by value for types that are not greater than two pointers in size

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • include/gsl/pointers: Language not supported

@carsonRadtke

Copy link
Copy Markdown
Member

Thanks for identifying this issue and posting a fix!

@carsonRadtke
Carson Radtke (carsonRadtke) merged commit 466e4eb into microsoft:main May 12, 2025
@github-project-automation github-project-automation Bot moved this from Ready for Review to Merged in Microsoft/GSL Pull Requests In-Flight May 12, 2025
social4hyq pushed a commit to social4hyq/homebrew-core that referenced this pull request Sep 20, 2026
cpp-gsl 5.0.0

Created-by: HarmonybrewBot
Commit-by: HarmonybrewBot
Merged-by: HarmonybrewBot
Description: Created by `brew bump`

---

Created with `brew bump-formula-pr`.<details>
  <summary>release notes</summary>
  <pre>## What's Changed
* Update return by value threshold in gsl::not_null by @ozaktash in microsoft/GSL#1205
* copilot: Provide more project context for the Copilot coding agent by @carsonRadtke in microsoft/GSL#1207
* Document differences between hardened std::span and gsl::span by @carsonRadtke with @Copilot in microsoft/GSL#1206
* Add constexpr to not_null comparison operators by @carsonRadtke with @Copilot in microsoft/GSL#1208
* fix: all pipeline failures by @carsonRadtke in microsoft/GSL#1221
* export proper syntax for GSL_SUPPRESS for new VS by @carsonRadtke in microsoft/GSL#1213
* Revert unintended change to GSL_SUPPRESS by @beinhaerter in microsoft/GSL#1226
* use cmake presets instead of cmake settings by @carsonRadtke in microsoft/GSL#1219
* Fix std::hash compilation error for gsl::not_null<std::shared_ptr<T>> by @carsonRadtke with @Copilot in microsoft/GSL#1210
* infra: individual test executables by @carsonRadtke in microsoft/GSL#1212
* doc: Update URL in pointers to F.16 C++ Core Guidelines by @maflcko in microsoft/GSL#1232
* doc: Fix to use lower-case anchors in links to C++ Core Guidelines by @maflcko in microsoft/GSL#1234
* gsl::not_null: C.85: Make swap noexcept by @maflcko in microsoft/GSL#1235
* gsl::not_null: C.89: Make a hash noexcept by @maflcko in microsoft/GSL#1236
* ci: Bump to actions/checkout@v6 by @maflcko in microsoft/GSL#1237
* ci: Use microsoft/setup-msbuild@v3 by @maflcko in microsoft/GSL#1240
* narrow_cast instead of static_cast by @beinhaerter in microsoft/GSL#1250
* ci: Bump actions/setup-java@v5 by @maflcko in microsoft/GSL#1249
* remove space in GSL_SUPPRESS by @beinhaerter in microsoft/GSL#1248
* clang-format improvements by @beinhaerter in microsoft/GSL#1251
* feat: implementation of gsl::dyn_array by @carsonRadtke in microsoft/GSL#1228
* ci: fix failing actions by @carsonRadtke in microsoft/GSL#1255
* docs: fix false statements in gsl::dyn_array docs by @carsonRadtke in microsoft/GSL#1254
* dyn_array: fix include tree by @carsonRadtke in microsoft/GSL#1261
* Bump GSL to v5.0.0 by @carsonRadtke in microsoft/GSL#1262
* docs: fix http:// to https:// in CppCoreGuidelines links by @Rajkaran-122 in microsoft/GSL#1267
* Fix floating-to-integral narrow undefined behavior by @carsonRadtke in microsoft/GSL#1266
* Ensure iterators convert to const iterators by @carsonRadtke in microsoft/GSL#1264
* Prevent external construction of checked iterators by @carsonRadtke in microsoft/GSL#1263

## New Contributors
* @ozaktash made their first contribution in microsoft/GSL#1205
* @maflcko made their first contribution in microsoft/GSL#1232
* @Rajkaran-122 made their first contribution in microsoft/GSL#1267

**Full Changelog**: https://github.com/microsoft/GSL/compare/v4.2.2...v5.0.0</pre>
  <p>View the full release notes at <a href="https://github.com/microsoft/GSL/releases/tag/v5.0.0">https://github.com/microsoft/GSL/releases/tag/v5.0.0</a>.</p>
</details>
<hr>

See merge request: Harmonybrew/homebrew-core!17783
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Review Needed Needs review from GSL maintainers Type: Enhancement Suggests an improvement or new feature

Projects

Development

Successfully merging this pull request may close these issues.

gsl::not_null should allow returning by value for the types whose size equals to the size of two pointers

3 participants