[jdx]

https://entire.io/gh/jdx/mise/trails/871

The [hooks] part of schema/mise.json is now generated from declaration types in mise-config, instead of 16 hand-written JSON definitions. Nothing changes for users: I compared the old and new schema/mise.json structurally and they are identical.

A hook can be a command string, { run = ... }, { script = ..., shell = ... }, { scripts = [...], shell = ... } or { task = ... }, and which of those an event accepts differs: enter, leave and cd evaluate a script in the active shell when shell is set, while preinstall and postinstall ignore the shell. The types now say that directly. For example:

// The same keys without a `shell` run in a subprocess, which is deprecated in favor of `run`.
pub struct HookSpawnedScriptTable {
    /// deprecated alias for run when an enter/leave/cd hook has no shell
    pub script: HookScripts,
}

where the doc comment is the description editors show and the deprecation is carried into the schema.

What changes for maintainers

• crates/mise-config/src/hooks/decl.rs holds the types: one per table shape (HookRunTableDecl, HookCurrentShellScriptTable, HookInstallScriptTable, ...), the unions of them an event accepts (HookDefinitionItem for enter/leave/cd, HookInstallDefinitionItem for the install events), and HooksDecl, which names the five events.
• The parser still reads one table, HookTable, for every event, and nothing parses into the new types. Two tests keep them from drifting: one checks that the declaration types name exactly the keys HookTable reads, and one checks that HooksDecl has an entry for each hook event. The events test uses an exhaustive match, so adding a Hooks variant fails to compile there until the schema has it.
• HookScripts now derives its own schema, replacing the hook_script_value definition.
• AGENTS.md says where to change hook shapes.

Validation

• Structural comparison of the old and new schema/mise.json: no differences.
• cargo +1.95 clippy --workspace --all-features --all-targets -- -D warnings
• cargo test -p mise-config (including schema_files_are_up_to_date and the two new tests) and cargo test -p mise --lib schema_matches_parser
• mise run test:e2e config/test_schema_ajv config/test_schema_tombi and the config/test_hooks* tests

Stacked on #14663.

AI-assisted — Tool: Claude Code; model: anthropic/claude-sonnet-5-5; version: 2.1.299.

🤖 Generated with Claude Code

---

Note

Low Risk
Refactor of schema generation and docs/tests only; hook parsing behavior is unchanged and the published schema is intended to be structurally equivalent.

Overview
[hooks] in schema/mise.json is now generated from Hook* declaration types in crates/mise-config/src/hooks/decl.rs, replacing the deleted hand-written hooks/schema.rs. Runtime parsing is unchanged: configs still deserialize through HookTable / HookDefItem.

Schema assembly wires those types through derived_defs in schema.rs (and drops the old schema_defs() chain). HookScripts now derives JsonSchema, and two unit tests keep declaration keys aligned with HookTable and hook events aligned with HooksDecl. AGENTS.md documents the new maintainer workflow.

Regenerated schema/mise.json is structurally the same for users; diffs are mostly key ordering and formatting from schemars.

^{Reviewed by Cursor Bugbot for commit b445620. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

Warning

Review limit reached

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Next included review available in 24 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 10 included reviews currently available.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

• Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
• Review profile: CHILL
• Plan: Advanced
• Run ID: ed3fcb84-aea4-454f-b42d-d1a4a81ef084

📥 Commits

Reviewing files that changed from the base of the PR and between a719280 and b445620.

📒 Files selected for processing: 6

• AGENTS.md
• crates/mise-config/src/hooks.rs
• crates/mise-config/src/hooks/decl.rs
• crates/mise-config/src/hooks/schema.rs
• crates/mise-config/src/schema.rs
• schema/mise.json

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Confidence Score: 5/5

[Low impact] The PR appears safe to merge; no actionable issues were found.

Summary

Replaces hand-written hook schemas with declaration types while leaving the runtime parser unchanged.

• The [hooks] schema now comes from typed declarations.

_{Reviews (2) · Last reviewed commit: "Merge branch 'claude/mise-config-type-da..." · Reviewed by Greptile}

Dismissed because a newer commit was pushed; Greptile will re-review the current head.

[github-actions]

Instruction counts

The comparison never ran — an earlier step failed.

_{b44562044bce vs `` · measured on the runner, not pushed to the history.}