Skip to content

drivers: imx: remove unnecessary blank lines - #7302

Merged
kv2019i merged 3 commits into
thesofproject:mainfrom
alaa-emad:new_branch
Mar 23, 2023
Merged

kv2019i merged 3 commits into
thesofproject:mainfrom
alaa-emad:new_branch

Conversation

@alaa-emad

Copy link
Copy Markdown
Contributor

Remove unnecessary blank lines before a close brace as reported by checkpatch script

"CHECK: Blank lines aren't necessary before a close brace '}'"

@alaa-emad
alaa-emad requested a review from dbaluta as a code owner March 19, 2023 10:35
@gkbldcig

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@sofci

sofci commented Mar 20, 2023

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

reply test this please to run this test once

@paulstelian97 paulstelian97 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have zero clue how these were introduced in the first place. Thanks.

@kv2019i kv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @alaa-emad !

@iuliana-prodan
iuliana-prodan self-requested a review March 20, 2023 09:08
@iuliana-prodan

Copy link
Copy Markdown
Contributor

Thank you @alaa-emad!

@alaa-emad

Copy link
Copy Markdown
Contributor Author

Thank you @alaa-emad !

Thank you

@alaa-emad

Copy link
Copy Markdown
Contributor Author

Thank you @alaa-emad !

Thanks

@lyakh

lyakh commented Mar 20, 2023

Copy link
Copy Markdown
Collaborator

I have zero clue how these were introduced in the first place. Thanks.

@paulstelian97 it was some scripted patching, where some code lines were removed, but it was more difficult to also remove empty lines around those lines

@dbaluta

dbaluta commented Mar 21, 2023

Copy link
Copy Markdown
Collaborator

@alaa-emad can you please the spelling error in commit message:

WARNING: 'blanck' may be misspelled - perhaps 'blank'?

@alaa-emad

Copy link
Copy Markdown
Contributor Author

@alaa-emad can you please the spelling error in commit message:

WARNING: 'blanck' may be misspelled - perhaps 'blank'?

yes, sure I will fix it.

Remove unnecessary blank lines before a close brace
as reported by checkpatch script

"CHECK: Blank lines aren't necessary before a close brace '}'"

Signed-off-by: Alaa Emad <eng.alaaemad.ae@gmail.com>
---
change in v2:
	edit subject line
Remove unnecessary blank line before a close brace as reported
by checkpatch:

"CHECK: Blank lines aren't necessary before a close brace '}'"

Signed-off-by: Alaa Emad <eng.alaaemad.ae@gmail.com>
---
change in v2:
	-edit subject line to include the file name.
Add blank line after struct declaration as reported
by checkpatch:

"WARNING: Missing a blank line after declarations"

Signed-off-by: Alaa Emad <eng.alaaemad.ae@gmail.com>
---
changes in v2:
	-edit subject line to include the file name.
	-edit commit message
@lgirdwood

Copy link
Copy Markdown
Member

test this please

@lgirdwood

Copy link
Copy Markdown
Member

SOFCI TEST

@kv2019i

kv2019i commented Mar 23, 2023

Copy link
Copy Markdown
Collaborator

Only Intel CI checks failing. As this PR does not touch files that affect Intel builds, it's safe to ignore these checks, not related to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants