Repository navigation
drivers: imx: fix checkpatch styling error - #7334
Conversation
|
Can one of the admins verify this patch?
|
|
Can one of the admins verify this patch? |
|
@jiande-my thanks for the pull request. Also, add a commit message and a commit description, for each patch. |
|
Test this please |
|
Besides the issues presented by Iuliana, I strongly recommend you visit https://thesofproject.github.io/latest/contribute/contribute_guidelines.html (specifically the developer certification of origin, but related pages are also important) and figure out the rules from that. |
jiande-my
changed the title
|
@iuliana-prodan I have resolved the issue you addressed. |
yes, thank you! |
Done |
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
One note on fallthrough.
And can you check the checkpatch failure in https://github.com/thesofproject/sof/actions/runs/4540557079/jobs/8001788774?pr=7334 ?
|
@jiande-my I think checkpatch is failing due to the text after your Signed-off-by line. |
`drivers: imx: ipc` Split long line into two short lines at 135: FILE: src/drivers/imx/ipc.c:135: "CHECK: line length of 103 exceeds 100 columns" Modified to match the alignment of the open parenthesis at 227: FILE: src/drivers/imx/ipc.c:227: "CHECK: Alignment should match open parenthesis" Split long line into two short lines at 309: FILE: src/drivers/imx/ipc.c:309: "CHECK: line length of 101 exceeds 100 columns" `drivers: imx: sai` Modified to match the alignment of the open parenthesis at 353: FILE: src/drivers/imx/sai.c:353: "CHECK: Alignment should match open parenthesis" Signed-off-by: Jian De <jiande2020@gmail.com>
kv2019i
left a comment
kv2019i
left a comment
There was a problem hiding this comment.
Looks ok now, let's see if the CI runs pass.
|
SOFCI TEST |
|
@wszypelt this doesn't touch any Intel driver code, so I'll override the failing Intel check. This has been pending for a looong time. |
drivers: imx: fix checkpatch styling error
drivers: imx: ipcSplit long line into two short lines
at 135: FILE: src/drivers/imx/ipc.c:135:
"CHECK: line length of 103 exceeds 100 columns"
Modified to match the alignment of the open parenthesis
at 227: FILE: src/drivers/imx/ipc.c:227:
"CHECK: Alignment should match open parenthesis"
Split long line into two short lines
at 309: FILE: src/drivers/imx/ipc.c:309:
"CHECK: line length of 101 exceeds 100 columns"
drivers: imx: saiModified to match the alignment of the open parenthesis
at 353: FILE: src/drivers/imx/sai.c:353:
"CHECK: Alignment should match open parenthesis"