Skip to content

drivers: imx: ipc: remove unnecessary blank line - #7333

Merged
kv2019i merged 1 commit into
thesofproject:mainfrom
alaa-emad:sec_branch
Mar 27, 2023
Merged

drivers: imx: ipc: remove unnecessary blank line#7333
kv2019i merged 1 commit into
thesofproject:mainfrom
alaa-emad:sec_branch

Conversation

@alaa-emad

@alaa-emad alaa-emad commented Mar 25, 2023

Copy link
Copy Markdown
Contributor

Remove unnecessary blank line after '{' as reported
by checkpatch:

"CHECK: Blank lines aren't necessary after an open
brace '{'".

Signed-off-by: Alaa Emad eng.alaaemad.ae@gmail.com

@alaa-emad
alaa-emad requested a review from dbaluta as a code owner March 25, 2023 14:24
@sofci

sofci commented Mar 25, 2023

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

reply test this please to run this test once

@gkbldcig

gkbldcig commented Mar 25, 2023

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@iuliana-prodan

iuliana-prodan commented Mar 26, 2023

Copy link
Copy Markdown
Contributor

Hi @alaa-emad!Thanks for your pull request but 3 of these commits were already merged in PR #7302 - so, please, remove those from this pull request.

The 4th commit should be a stand alone PR.
Also, while on ipc.c can you please check other checkpatch issues.

Thanks!

@alaa-emad

alaa-emad commented Mar 26, 2023

Copy link
Copy Markdown
Contributor Author

Hi @alaa-emad!Thanks for your pull request but 3 of these commits were already merged in PR #7302 - so, please, remove those from this pull request.

The 4th commit should be a stand alone PR. Also, while on ipc.c can you please check other checkpatch issues.

yes, sorry this happened by mistake, I will try to fix it and sure I will check other checkpatch issues.

Thanks!

@alaa-emad
drivers: imx: ipc: remove unnecessary blank line
b1c4d3e 
Remove unnecessary blank line after '{' as reported
by checkpatch:

"CHECK: Blank lines aren't necessary after an open
brace '{'".

Signed-off-by: Alaa Emad <eng.alaaemad.ae@gmail.com>
iuliana-prodan
iuliana-prodan approved these changes Mar 26, 2023
View reviewed changes

@iuliana-prodan iuliana-prodan left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @alaa-emad

@alaa-emad

alaa-emad commented Mar 26, 2023

Copy link
Copy Markdown
Contributor Author

Thanks @alaa-emad

appreciate your help

@kv2019i
kv2019i merged commit 51156a7 into thesofproject:main Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dbaluta dbaluta dbaluta approved these changes
@paulstelian97 paulstelian97 paulstelian97 approved these changes
@iuliana-prodan iuliana-prodan iuliana-prodan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@alaa-emad @sofci @gkbldcig @iuliana-prodan @dbaluta @paulstelian97 @kv2019i