Skip to content

fix(models): separate WX200 arm and gripper joints - #739

Open
huxiaoyi-ovo wants to merge 3 commits into
petercorke:mainfrom
huxiaoyi-ovo:validation/wx200-arm-gripper-729
Open

huxiaoyi-ovo wants to merge 3 commits into
petercorke:mainfrom
huxiaoyi-ovo:validation/wx200-arm-gripper-729

Conversation

@huxiaoyi-ovo

Copy link
Copy Markdown
Contributor

Summary

Partially addresses #729 by correcting the WX200 model's arm/gripper kinematic split and default tool pose.

  • Separate the five arm joints from the gripper's three joints using the existing gripper_link_name interface.
  • Align the default tool pose with the URDF's ee_gripper_link frame.
  • Replace the invalid qr configuration and update qz to match the arm's five DOFs.
  • Add regression tests for joint counts, end-effector linkage, tool-frame consistency, and joint-limit compliance.

This change is intentionally limited to WX200. The remaining Interbotix models can be addressed separately under #729.

Validation

Full CI completed successfully: 19 successful jobs, 0 failures, with one unrelated Dependabot job skipped.

Verified across Linux, macOS, and Windows, including Python 3.10–3.14, core tests, coverage, and documentation build.

CI: https://github.com/huxiaoyi-ovo/robotics-toolbox-python/actions/runs/38212915312

Fork validation PR: huxiaoyi-ovo#3

@codacy-production

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · -2 duplication

Metric Results
Complexity 0
Duplication -2

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@codecov

codecov Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (4a93c88) to head (a1b3831).

Files with missing lines Patch % Lines
src/roboticstoolbox/models/URDF/wx200.py 0.00% 4 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff          @@
##            main    #739   +/-   ##
=====================================
  Coverage   0.00%   0.00%           
=====================================
  Files        144     144           
  Lines      14819   14821    +2     
=====================================
- Misses     14819   14821    +2     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@petercorke

Copy link
Copy Markdown
Owner

Thank you for this, and for the tests. The WX200 changes match the URDF. I'm pausing changes that touch grippers while we decide how they should be modeled, see #884, so I won't merge this now. I'll leave it open as a record and come back to it afterwards. You're welcome to join the discussion in #884, your experience with these models would help.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants