Skip to content

test: pin java relock e2e to a fully published Temurin line - #14940

Merged
jdx merged 2 commits into
mainfrom
fix/e2e-java-shorthand-partial-release
Oct 24, 2026
Merged

jdx merged 2 commits into
mainfrom
fix/e2e-java-shorthand-partial-release

Conversation

@jdx

@jdx jdx commented Oct 24, 2026 •

Copy link
Copy Markdown
Owner

https://entire.com/gh/jdx/-/trails/2807/changes/mise/1029

core/test_java_shorthand_vendor_slow locked java 17 and expected the newest Temurin 17 build to resolve on every platform. On 2026-10-22 Adoptium published Temurin 17.0.21+9 with only linux-x64 and mac-aarch64 binaries, so mise lock --bump java refused to replace the locked 17.0.2 entries for windows-x64, linux-arm64 and macos-x64. That failed e2e-linux-7 and trusted / e2e on the 2026.10.19 release PR (#14892), and left test-ci and release red.

mise's behavior is correct here; the test just shouldn't depend on whichever upstream build is newest. The bump step now uses a java = "17.0.20" request, a line published for all platforms. The final vendor-switch section uses java = "17.0.2" for both the OpenJDK and Temurin locks, so it still checks that an uninstalled OpenJDK entry is replaced under the same request; Temurin's 17.0.2+8 is fixed metadata that upstream releases can't change. The other OpenJDK steps keep java = "17". The assertions are unchanged apart from the expected "not in the lockfile" message naming java@17.0.2.

Validated by running TEST_ALL=1 mise run test:e2e core/test_java_shorthand_vendor_slow locally while Temurin 17.0.21+9 was still partial; it passes.

AI-assisted — Tool: Claude Code; model: anthropic/claude-sonnet-5-5; version: claude-code_2-1-308_agent.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Tests
    • Expanded automated coverage for Java lockfile updates, including version validation and handling of a vendor mismatch during locked installation.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Entire-Checkpoint: 01M5Q34V5DDAHRKBQZWZSST1P9
@coderabbitai

coderabbitai Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 25e29c3 and 1f2bcc2.

Files selected for processing: 1
  • e2e/core/test_java_shorthand_vendor_slow

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

Walkthrough

The end-to-end test pins Java to 17.0.20 before bumping the lock and checks the resulting Temurin entry. It then restores the 17.0.2 pin and checks locked installation after creating an OpenJDK lock entry.

Changes: Java shorthand lock test

Layer / File(s) Summary
Bump and vendor lock checks
e2e/core/test_java_shorthand_vendor_slow
The test checks that the bumped Temurin entry matches the expected version format and excludes download.java.net. It then creates an OpenJDK lock entry and expects locked installation to fail because java@17.0.2 is absent from the lockfile.

Priority: Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: Minimal · up to 1f2bc

The test update is consistent with its stated purpose and is mergeable.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: pinning the Java relock E2E test to a fully published Temurin line.
Docstring Coverage Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

RetriggerView in GreptileConfidence Score: 5/5

[Low impact] The PR appears safe to merge; no new actionable issues were found.

Summary

Pins the Java relock test to known release lines without changing application code.

  • The Java vendor test pins its bump and vendor-switch requests.

Reviews (2) · Last reviewed commit: "test: keep the same java request across ..." · Reviewed by Greptile

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Entire-Checkpoint: 01M5Q3J1PFT0HQK5GFSS70Z200
@jdx
jdx enabled auto-merge (squash) October 24, 2026 14:24
@jdx
jdx merged commit cb34931 into main Oct 24, 2026
65 of 68 checks passed
@jdx
jdx deleted the fix/e2e-java-shorthand-partial-release branch October 24, 2026 14:30
mise-en-dev added a commit that referenced this pull request Oct 24, 2026
<!-- entire-trail-link-start -->
https://entire.com/gh/jdx/-/trails/2718/changes/mise/998
<!-- entire-trail-link-end -->

### 🚀 Features

- **(config)** expose mise_config_dir to templates by @jdx in
[#14886](#14886)
- **(lsp)** send semantic tokens for tasks, tools, env vars and
templates by @jdx in [#14918](#14918)

### 🐛 Bug Fixes

- **(lock)** rebuild lockfiles completely by default by @jdx in
[#14893](#14893)
- **(pipx)** list git+ssh github.com sources over ssh when GitHub can't
see them by @jdx in [#14905](#14905)
- **(python)** stop uv_venv_auto from fork-bombing through python shims
by @jdx in [#14927](#14927)
- **(task)** apply extended template usage to file tasks by @jdx in
[#14888](#14888)
- **(task)** quote and escape header values written by tasks add --file
by @xucian in [#14925](#14925)
- **(uninstall)** remove installs whose directories deny their owner
writes by @HengYangDS in
[#14883](#14883)
- **(upgrade)** don't downgrade date-versioned tools with leading zeros
by @jdx in [#14923](#14923)

### 📚 Documentation

- tell agents not to edit the vendored aqua registry by @jdx in
[#14910](#14910)

### 🧪 Testing

- update e2e expectations after version validation moved earlier by @jdx
in [#14920](#14920)
- pin java relock e2e to a fully published Temurin line by @jdx in
[#14940](#14940)

### 📦️ Dependency Updates

- bump ctutils to 0.4.5 by @jdx in
[#14887](#14887)
- update aube to v2.8.2 by @renovate[bot] in
[#14889](#14889)
- update rust crate clx to v3.0.5 by @renovate[bot] in
[#14890](#14890)
- ignore RUSTSEC-2026-0387 in cargo-deny by @jdx in
[#14939](#14939)

### Ci

- retry snapcraft upload on transient store errors by @jdx in
[#14909](#14909)

### Security

- **(backend)** keep untrusted values out of subprocess arguments and
the project directory by @jdx in
[#14896](#14896)
- **(backend)** keep archive contents and release asset names inside the
install directory by @jdx in
[#14895](#14895)
- **(backend)** validate versions and names that become paths or URL
segments by @jdx in [#14901](#14901)
- **(backend)** tighten SLSA signer and GitHub attestation checks by
@jdx in [#14904](#14904)
- **(backend)** make SLSA, attestation and signed-checksum checks fail
closed by @jdx in [#14908](#14908)
- **(backend)** reject SLSA provenance built from another tag by @jdx in
[#14924](#14924)
- **(completion)** stop shell completion from running untrusted task
code by @jdx in [#14898](#14898)
- **(config)** tie trust to the right files for worktrees, symlinks and
config dirs by @jdx in [#14902](#14902)
- **(config)** close safe-mode gaps for lazy tools, deps, S3, bin_path
and templates by @jdx in
[#14900](#14900)
- **(config)** stop treating help, shims, hooks and config writes as
consent to trust by @jdx in
[#14903](#14903)
- **(config)** keep untrusted repo content from hanging or crashing
hook-env by @jdx in [#14916](#14916)
- **(github)** send forge tokens only to their API host and harden
release caches by @jdx in
[#14913](#14913)
- **(hooks)** render hook commands once and keep templates out of
written versions by @jdx in
[#14897](#14897)
- **(http)** bound response, download and archive sizes and slow
response bodies by @jdx in
[#14915](#14915)
- **(install)** enforce pinned checksums and node signatures instead of
falling back by @jdx in [#14899](#14899)
- **(lockfile)** stop lockfiles, tool stubs and the task cache from
reaching outside the repo by @jdx in
[#14906](#14906)
- **(packslip)** pin signers by repository ID and stop release-age
backdating by @jdx in [#14912](#14912)
- **(task)** close sandbox escapes in --allow-write, --deny-net and
--deny-write, and OCI whiteouts by @jdx in
[#14911](#14911)
- keep credentials out of install paths, lockfiles, logs and redirects
by @jdx in [#14917](#14917)

### New Contributors

- @xucian made their first contribution in
[#14925](#14925)
- @HengYangDS made their first contribution in
[#14883](#14883)

## 📦 Aqua Registry Updates

### New Packages (5)

- [`Future-Element/pinset`](https://github.com/Future-Element/pinset)
-
[`bronto-community/bronto-cli`](https://github.com/bronto-community/bronto-cli)
- [`faberlang/releases/faber`](https://github.com/faberlang/releases)
- [`muvon/octomind`](https://github.com/muvon/octomind)
- [`pratyay360/ensor`](https://github.com/pratyay360/ensor)

### Updated Packages (5)

- [`anomalyco/opencode`](https://github.com/anomalyco/opencode)
- [`duckdb/duckdb`](https://github.com/duckdb/duckdb)
- [`grafana/gcx`](https://github.com/grafana/gcx)
- [`grafana/mcp-grafana`](https://github.com/grafana/mcp-grafana)
- [`magefile/mage`](https://github.com/magefile/mage)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant