Skip to content

gitignore: remove autotools ignore files - #895

Merged
lgirdwood merged 1 commit into
masterfrom
lrg/topic/gitignore
Mar 27, 2019
Merged

lgirdwood merged 1 commit into
masterfrom
lrg/topic/gitignore

Conversation

@lgirdwood

Copy link
Copy Markdown
Member

Signed-off-by: Liam Girdwood liam.r.girdwood@linux.intel.com

@jajanusz jajanusz left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I didn't explain at all what '..' are in cmake snippets + I made builddirs in repo there to make samples simpler - These dots are path to root cmake file, you can call cmake generator from anywhere.

You can use cmake build dir just like any other out-of-source build (for example KBUILD_OUTPUT/O in Linux).
So users that don't want to have any build output in repo can make dir somewhere out of the repo.

If we want to make life easier for people that have builddirs in repo I think it would be better to just ignore build*/ folders (There are some projects that do that).

@lgirdwood

Copy link
Copy Markdown
Member Author

@jajanusz Ok, sounds like you are in a better position to fix gitignore wrt CMake runtime files ? Fwiw, there were some files outside the build dir that showed up with git.

I can send a subsequent PR to remove all the gitignore autotools files once CMake gitignore is merged. This sound OK ?

@jajanusz

Copy link
Copy Markdown
Contributor

@lgirdwood
Sounds good.

What files were there? AFAIK when you do out-of-source build the only files that will be added outside of builddir are __pycache__ files (what can be disabled with cmdline args). Maybe they were files from autotools? - Also please note that tools/ folder has separate buildsystem that I didn't touch - I guess we want to remove autotools everywhere so I'll port tools/ buildsystem soon too.

@lgirdwood

Copy link
Copy Markdown
Member Author

if you run git clean -f -d -x and then build for any target git gui will show some files in arch/.

Autotools not used anymore so remove ignore files.

Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
@lgirdwood
lgirdwood force-pushed the lrg/topic/gitignore branch from 58bb083 to f312c02 Compare January 29, 2019 13:36
@lgirdwood lgirdwood changed the title gitignore: update for CMake cache and dependency files gitignore: remove autotools ignore files Jan 29, 2019
@lgirdwood

Copy link
Copy Markdown
Member Author

@jajanusz this looks good for after autotools remove for tools. Do you have an ETA for this ?

@jajanusz

Copy link
Copy Markdown
Contributor

@jajanusz this looks good for after autotools remove for tools. Do you have an ETA for this ?

I'll try to do it this week.

@jajanusz

Copy link
Copy Markdown
Contributor

I guess it's not longer needed because of #899

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants