Skip to content

build: add automatically generated files to .gitignore - #941

Closed
lyakh wants to merge 1 commit into
thesofproject:masterfrom
lyakh:gitignore
Closed

lyakh wants to merge 1 commit into
thesofproject:masterfrom
lyakh:gitignore

Conversation

@lyakh

@lyakh lyakh commented Feb 1, 2019

Copy link
Copy Markdown
Collaborator

With the transition to Kconfig more automatically generated files and
directories have to be added to .gitignore.

With the transition to Kconfig more automatically generated files and
directories have to be added to .gitignore.

Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
@jajanusz

jajanusz commented Feb 1, 2019

Copy link
Copy Markdown
Contributor

@lyakh @lgirdwood
We discussed it in #895
You are better to not have these files in source tree at all.
Other cmake-based projects don't add cmake generated files to .gitignore, I also think it's a bad practice because it needs to be maintained when output of cmake cache/settings/whatever may change and you shouldn't care about it.

@jajanusz jajanusz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to not care about cmake generation internals. User should follow build*/ folders convention that is already .gitignored or build out of repo.

@lyakh

lyakh commented Feb 1, 2019

Copy link
Copy Markdown
Collaborator Author

Ah, got it, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants