Repository navigation
CMake: prevent in-source build and update gitignore - #899
Merged
Merged
Conversation
Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
Signed-off-by: Janusz Jankowski <janusz.jankowski@linux.intel.com>
jajanusz
requested review from
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
January 27, 2019 20:24
lgirdwood
approved these changes
Jan 28, 2019
Member
|
@jajanusz can you check CI, should have completed by now but still shows pending ? |
Contributor
Author
|
@lgirdwood |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prevent in-source build, because they are usually bad idea (common in cmake projects to prevent this).
Gitignore build* folders (as for cmake convention) and CMakeCache.txt+CMakeFiles that are generated for unsuccessful in-source build.
Follow-up to #895