Skip to content

[release-4.21] OCPBUGS-133333: Cap rendered alerts in notification drawer and dashboards - #17429

Open
fsgreco wants to merge 1 commit into
openshift:release-4.21from
fsgreco:OCPBUGS-133333--release-4.21--cap-rendered-notification-drawer
Open

fsgreco wants to merge 1 commit into
openshift:release-4.21from
fsgreco:OCPBUGS-133333--release-4.21--cap-rendered-notification-drawer

Conversation

@fsgreco

@fsgreco fsgreco commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

This is a manual backport of #17378 to release-4.21.

Jira: OCPBUGS-133333

Original implementation and discussion: #17324.

Analysis / Root cause:

The notification drawer and dashboard alert lists rendered every firing alert. Large alert volumes increase rendering work and can make the Console slow or unresponsive.

Solution description:

Render at most 50 alerts in each notification drawer group and dashboard alert list. When a list exceeds the cap, show its full alert count and a link to the complete alert list. Drawer and cluster dashboard links select all namespaces; the namespaced dashboard link preserves the selected namespace.

This backport retains release-4.21's drawer structure and test infrastructure. The test uses jest 22-compatible APIs and routes from react-router-dom-v5-compat. No dependencies or public SDK APIs change.

Test cases:

Passed locally:

  • Notification drawer Jest suite: 8 tests covering 5, 50, and 200 alerts in critical and warning groups, full overflow counts, and all-namespace selection/navigation.
  • Targeted ESLint for both changed production components and the drawer test.
  • i18n generation, adding only the two intended plural keys.
  • Webpack cycle check.

I (@fsgreco) manually checked the drawer, cluster dashboard, and project dashboard alert cap with 156 firing alerts on a 4.21 development build against a live cluster and confirmed the smoke check passed. The temporary AlertingRule was removed afterward.

Full alert-list destination navigation could not be verified on this backport because the monitoring plugin is not included in the local development build. High-volume load testing beyond 156 alerts has not been checked on this backport.

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:

  • Immediate source commit: 85b6860.
  • Original source commit: 19d0e53.
  • Backport risk assessment: the change limits rendered entries and adds overflow links while preserving the complete alert data and the existing 4.21 state model. Fetched data and alert grouping work remain unchanged.

…ards

Manually backport the alert rendering cap from openshift#17378
into release-4.21. Limit each drawer alert group and dashboard alert
list to 50 entries to reduce rendering work under high alert volume,
while preserving full counts and links to all alerts.

Adapt the test to the jest 22 toolchain and 4.21 test infrastructure.

Source commit: 85b6860
Original commit: 19d0e53
Jira: https://redhat.atlassian.net/browse/OCPBUGS-133333

Assisted-by: GLM 5.3
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification

This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration.

Use /test ? to list jobs and /pipeline help for commands.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 26, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@fsgreco: This pull request references Jira Issue OCPBUGS-133333, which is invalid:

  • expected the bug to target the "4.21.z" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual backport of #17378 to release-4.21.

Jira: OCPBUGS-133333

Original implementation and discussion: #17324.

Analysis / Root cause:

The notification drawer and dashboard alert lists rendered every firing alert. Large alert volumes increase rendering work and can make the Console slow or unresponsive.

Solution description:

Render at most 50 alerts in each notification drawer group and dashboard alert list. When a list exceeds the cap, show its full alert count and a link to the complete alert list. Drawer and cluster dashboard links select all namespaces; the namespaced dashboard link preserves the selected namespace.

This backport retains release-4.21's drawer structure and test infrastructure. The test uses jest 22-compatible APIs and routes from react-router-dom-v5-compat. No dependencies or public SDK APIs change.

Test cases:

Passed locally:

  • Notification drawer Jest suite: 8 tests covering 5, 50, and 200 alerts in critical and warning groups, full overflow counts, and all-namespace selection/navigation.
  • Targeted ESLint for both changed production components and the drawer test.
  • i18n generation, adding only the two intended plural keys.
  • Webpack cycle check.

I (@fsgreco) manually checked the drawer, cluster dashboard, and project dashboard alert cap with 156 firing alerts on a 4.21 development build against a live cluster and confirmed the smoke check passed. The temporary AlertingRule was removed afterward.

Full alert-list destination navigation could not be verified on this backport because the monitoring plugin is not included in the local development build. High-volume load testing beyond 156 alerts has not been checked on this backport.

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:

  • Immediate source commit: 85b6860.
  • Original source commit: 19d0e53.
  • Backport risk assessment: the change limits rendered entries and adds overflow links while preserving the complete alert data and the existing 4.21 state model. Fetched data and alert grouping work remain unchanged.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 4fc9dbd6-11d4-47c8-b320-8ecfd0a6a01b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci
openshift-ci Bot requested review from cajieh and spadgett October 26, 2026 11:28
@openshift-ci openshift-ci Bot added the component/core Related to console core functionality label Oct 26, 2026
@openshift-ci

openshift-ci Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: fsgreco
Once this PR has been reviewed and has the lgtm label, please assign rhamilto for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added component/dashboard Related to dashboard kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Oct 26, 2026
@fsgreco

fsgreco commented Oct 26, 2026

Copy link
Copy Markdown
Contributor Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Oct 26, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@fsgreco: This pull request references Jira Issue OCPBUGS-133333, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.21.z) matches configured target version for branch (4.21.z)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-129621 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-129621 targets the "4.22" version, which is one of the valid target versions: 4.22.0
  • bug has dependents
Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci

openshift-ci Bot commented Oct 26, 2026

Copy link
Copy Markdown
Contributor

@fsgreco: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/core Related to console core functionality component/dashboard Related to dashboard jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants