Skip to content

[release-4.22] OCPBUGS-129621: Cap rendered alerts in notification drawer and dashboards - #17378

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.22from
fsgreco:OCPBUGS-129621--release-4.22--fix-not-drawer
Oct 19, 2026
Merged

openshift-merge-bot[bot] merged 1 commit into
openshift:release-4.22from
fsgreco:OCPBUGS-129621--release-4.22--fix-not-drawer

Conversation

@fsgreco

@fsgreco fsgreco commented Oct 12, 2026

Copy link
Copy Markdown
Contributor

This is a manual backport of openshift/console#17367 to release-4.22.

Jira: OCPBUGS-129621

Original implementation and discussion: openshift/console#17324.

Analysis / Root cause:

The notification drawer and dashboard alert lists rendered every firing alert. Large alert volumes increase rendering work and can make the Console slow or unresponsive.

Solution description:

Render at most 50 alerts in each notification drawer group and dashboard alert list. When a list exceeds the cap, show its full alert count and a link to the complete alert list. Drawer and cluster dashboard links select all namespaces; the namespaced dashboard link preserves the selected namespace.

This backport retains release-4.22's drawer structure, Immutable Redux handling, and public~ translation syntax. The source tests use the branch's existing detect-namespace context and default ToastProvider export. No dependencies or public SDK APIs change.

Test cases:

Passed locally:

  • Notification drawer Jest suite: 8 tests covering 5, 50, and 200 alerts in critical and warning groups, full overflow counts, and all-namespace selection/navigation.
  • Targeted ESLint for both changed production components and the drawer test.
  • Target i18n generation, adding only the two intended plural keys.
  • Production frontend build and git diff --check.

I (@fsgreco) manually checked the drawer/dashboard alert cap with the 60-alert fixture on a 4.22 cluster and confirmed the smoke check passed. The temporary AlertingRule was removed afterward.

Full alert-list destination navigation with the monitoring plugin, namespaced dashboard behavior, and high-volume load testing have not been checked on this backport. The browser used for the manual smoke check was not recorded. Release-5.0 testing is not included in these results.

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:

Manually backport the alert rendering cap from openshift#17367
into release-4.22. Limit each drawer alert group and dashboard alert
list to 50 entries to reduce rendering work under high alert volume,
while preserving full counts and links to all alerts.

Retain release-4.22's drawer structure and Immutable Redux handling.
Adapt namespace and ToastProvider test imports and preserve the
public~ translation key convention.

Source commit: 5bfe444
Original commit: 19d0e53
Jira: https://redhat.atlassian.net/browse/OCPBUGS-129621

Assisted-by: Codex <OpenAI>
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification

This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration.

Use /test ? to list jobs and /pipeline help for commands.

@openshift-ci-robot openshift-ci-robot added jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. labels Oct 12, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@fsgreco: This pull request references Jira Issue OCPBUGS-129621, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.22.0) matches configured target version for branch (4.22.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)
  • release note text is set and does not match the template
  • dependent bug Jira Issue OCPBUGS-129474 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
  • dependent Jira Issue OCPBUGS-129474 targets the "5.0" version, which is one of the valid target versions: 5.0.0
  • bug has dependents

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

This is a manual backport of openshift/console#17367 to release-4.22.

Jira: OCPBUGS-129621

Original implementation and discussion: openshift/console#17324.

Analysis / Root cause:

The notification drawer and dashboard alert lists rendered every firing alert. Large alert volumes increase rendering work and can make the Console slow or unresponsive.

Solution description:

Render at most 50 alerts in each notification drawer group and dashboard alert list. When a list exceeds the cap, show its full alert count and a link to the complete alert list. Drawer and cluster dashboard links select all namespaces; the namespaced dashboard link preserves the selected namespace.

This backport retains release-4.22's drawer structure, Immutable Redux handling, and public~ translation syntax. The source tests use the branch's existing detect-namespace context and default ToastProvider export. No dependencies or public SDK APIs change.

Test cases:

Passed locally:

  • Notification drawer Jest suite: 8 tests covering 5, 50, and 200 alerts in critical and warning groups, full overflow counts, and all-namespace selection/navigation.
  • Targeted ESLint for both changed production components and the drawer test.
  • Target i18n generation, adding only the two intended plural keys.
  • Production frontend build and git diff --check.

I (@fsgreco) manually checked the drawer/dashboard alert cap with the 60-alert fixture on a 4.22 cluster and confirmed the smoke check passed. The temporary AlertingRule was removed afterward.

Full alert-list destination navigation with the monitoring plugin, namespaced dashboard behavior, and high-volume load testing have not been checked on this backport. The browser used for the manual smoke check was not recorded. Release-5.0 testing is not included in these results.

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
openshift-ci Bot requested review from cajieh and spadgett October 12, 2026 13:02
@openshift-ci openshift-ci Bot added component/core Related to console core functionality component/dashboard Related to dashboard kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated labels Oct 12, 2026
@fsgreco

fsgreco commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

/pipeline required

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-gcp-console

@fsgreco

fsgreco commented Oct 13, 2026

Copy link
Copy Markdown
Contributor Author

/test e2e-gcp-console

@fsgreco

fsgreco commented Oct 15, 2026

Copy link
Copy Markdown
Contributor Author

/verified by ci/prow/frontend

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Oct 15, 2026
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@fsgreco: This PR has been marked as verified by ci/prow/frontend.

Details

In response to this:

/verified by ci/prow/frontend

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@logonoff logonoff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/label backport-risk-assessed

@openshift-ci openshift-ci Bot added the backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. label Oct 19, 2026

@logonoff logonoff left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci

openshift-ci Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fsgreco, logonoff

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 19, 2026
@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Oct 19, 2026
@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Scheduling tests matching the pipeline_run_if_changed or not excluded by pipeline_skip_if_only_changed parameters:
/test e2e-gcp-console

@openshift-ci

openshift-ci Bot commented Oct 19, 2026

Copy link
Copy Markdown
Contributor

@fsgreco: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot
openshift-merge-bot Bot merged commit 7c491b4 into openshift:release-4.22 Oct 19, 2026
9 checks passed
@openshift-ci-robot

Copy link
Copy Markdown
Contributor

@fsgreco: Jira Issue Verification Checks: Jira Issue OCPBUGS-129621
✔️ This pull request was pre-merge verified.
✔️ All associated pull requests have merged.
✔️ All associated, merged pull requests were pre-merge verified.

Jira Issue OCPBUGS-129621 has been moved to the MODIFIED state and will move to the VERIFIED state when the change is available in an accepted nightly payload. 🕓

Details

In response to this:

This is a manual backport of openshift/console#17367 to release-4.22.

Jira: OCPBUGS-129621

Original implementation and discussion: openshift/console#17324.

Analysis / Root cause:

The notification drawer and dashboard alert lists rendered every firing alert. Large alert volumes increase rendering work and can make the Console slow or unresponsive.

Solution description:

Render at most 50 alerts in each notification drawer group and dashboard alert list. When a list exceeds the cap, show its full alert count and a link to the complete alert list. Drawer and cluster dashboard links select all namespaces; the namespaced dashboard link preserves the selected namespace.

This backport retains release-4.22's drawer structure, Immutable Redux handling, and public~ translation syntax. The source tests use the branch's existing detect-namespace context and default ToastProvider export. No dependencies or public SDK APIs change.

Test cases:

Passed locally:

  • Notification drawer Jest suite: 8 tests covering 5, 50, and 200 alerts in critical and warning groups, full overflow counts, and all-namespace selection/navigation.
  • Targeted ESLint for both changed production components and the drawer test.
  • Target i18n generation, adding only the two intended plural keys.
  • Production frontend build and git diff --check.

I (@fsgreco) manually checked the drawer/dashboard alert cap with the 60-alert fixture on a 4.22 cluster and confirmed the smoke check passed. The temporary AlertingRule was removed afterward.

Full alert-list destination navigation with the monitoring plugin, namespaced dashboard behavior, and high-volume load testing have not been checked on this backport. The browser used for the manual smoke check was not recorded. Release-5.0 testing is not included in these results.

Browser conformance:

  • Chrome
  • Firefox
  • Safari (or Epiphany on Linux)

Additional info:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@fsgreco

fsgreco commented Oct 19, 2026

Copy link
Copy Markdown
Contributor Author

/cherry-pick release-4.21

@openshift-cherrypick-robot

Copy link
Copy Markdown

@fsgreco: #17378 failed to apply on top of branch "release-4.21":

Applying: OCPBUGS-129621: Cap rendered alerts in drawer and dashboards
Using index info to reconstruct a base tree...
M	frontend/public/components/dashboard/dashboards-page/cluster-dashboard/status-card.tsx
M	frontend/public/components/notification-drawer.tsx
M	frontend/public/locales/en/public.json
Falling back to patching base and 3-way merge...
Auto-merging frontend/public/components/dashboard/dashboards-page/cluster-dashboard/status-card.tsx
CONFLICT (content): Merge conflict in frontend/public/components/dashboard/dashboards-page/cluster-dashboard/status-card.tsx
Auto-merging frontend/public/components/notification-drawer.tsx
Auto-merging frontend/public/locales/en/public.json
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 OCPBUGS-129621: Cap rendered alerts in drawer and dashboards

Details

In response to this:

/cherry-pick release-4.21

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-merge-robot

Copy link
Copy Markdown
Contributor

Fix included in release 4.22.0-0.nightly-2026-10-20-070613

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. backport-risk-assessed Indicates a PR to a release branch has been evaluated and considered safe to accept. component/core Related to console core functionality component/dashboard Related to dashboard jira/severity-important Referenced Jira bug's severity is important for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. kind/i18n Indicates issue or PR relates to internationalization or has content that needs to be translated lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants