Skip to content

security(deps): update rustls to 0.23.46 - #14434

Merged
jdx merged 1 commit into
mainfrom
chore/deps-rustls-0.23.46
Oct 14, 2026
Merged

jdx merged 1 commit into
mainfrom
chore/deps-rustls-0.23.46

Conversation

@jdx

@jdx jdx commented Oct 14, 2026 •

Copy link
Copy Markdown
Owner

https://entire.io/gh/jdx/mise/trails/724

cargo deny check now fails on rustls 0.23.45: its Debug impls for Tls12ClientSessionValue and Tls13ClientSessionValue print the TLS 1.2 master secret or TLS 1.3 resumption PSK (rustls/rustls#3299, fixed in 0.23.46). The advisory is not yet numbered (RUSTSEC-0000-0000). This makes trusted / lint red on every open PR.

mise does not format those values with Debug; the dependency path is the AWS SDK's HTTP client, so the exposure is limited to anything that would log a custom session store's values. The bump is a lockfile-only change (cargo update -p rustls --precise 0.23.46; it also moves rustls's getrandom dependency from 0.4.3 to 0.3.4), with no Cargo.toml change.

Validation: cargo check --bin mise builds. I could not run cargo deny locally (the shim has no installed version here), so CI's trusted / lint is the check.

AI-assisted — Tool: Claude Code; model: anthropic/claude-sonnet-5-5; version: claude-code_2-1-295_agent.

🤖 Generated with Claude Code


Note

Low Risk
Patch-level TLS library upgrade with no application code changes; reduces secret-leak risk in debug output rather than changing runtime TLS behavior.

Overview
Bumps rustls from 0.23.45 to 0.23.46 in Cargo.lock only (no Cargo.toml edits), addressing a pending RustSec issue where Debug on TLS session types could leak the TLS 1.2 master secret or TLS 1.3 resumption PSK—fixing failing cargo deny / trusted / lint on PRs.

The lockfile refresh also pins tempfile’s transitive getrandom dependency to 0.3.4 instead of 0.4.3 as part of the same cargo update -p rustls resolution.

Reviewed by Cursor Bugbot for commit e74cbfd. Bugbot is set up for automated code reviews on this repo. Configure here.

cargo deny now fails on rustls 0.23.45, whose Debug impls for client
session values expose TLS secrets, so the lint job is red on every PR.

Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
Entire-Checkpoint: 01M4X6W7VYF8NWNB4S26GHS94N
@greptile-apps

greptile-apps Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

No reviewable files after applying ignore patterns.

@coderabbitai

coderabbitai Bot commented Oct 14, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters: 1
  • Cargo.lock is excluded by !**/*.lock

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

⚙️ Run configuration
  • Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 81400c12-f292-4a72-9102-74e18982d578

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jdx
jdx enabled auto-merge (squash) October 14, 2026 13:15
@jdx
jdx merged commit a123781 into main Oct 14, 2026
64 of 69 checks passed
@jdx
jdx deleted the chore/deps-rustls-0.23.46 branch October 14, 2026 13:16
@github-actions

Copy link
Copy Markdown
Contributor

Instruction counts

benchmark trend instructions Δ wall (min) Δ
env ▇▇█▂▅▅▆▄▁ 27,717,813 → 27,693,008 -0.09% 19.73 → 19.36ms -1.86%
hook-env ▅▃▇▇▅▁█▃▂ 29,974,360 → 29,967,023 -0.02% 21.03 → 20.37ms -3.12%
ls ▆▅█▃▄▇▆▃▁ 31,895,068 → 31,876,496 -0.06% 21.93 → 21.58ms -1.57%
registry █▇▇▅▆█▆▆▁ 40,028,122 → 39,959,283 -0.17% 17.78 → 17.83ms +0.26%
startup ▅▂█▇▃▄▄▆▁ 11,034,128 → 11,011,780 -0.20% 11.81 → 12.31ms +4.26%

No instruction-count regression above 1%.

Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run.

Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.

e74cbfdb93b9 vs 22717299563d · measured on the runner, not pushed to the history.

mise-en-dev added a commit that referenced this pull request Oct 15, 2026
<!-- entire-trail-link-start -->
https://entire.io/gh/jdx/mise/trails/726
<!-- entire-trail-link-end -->

### 🚀 Features

- **(bootstrap)** add --upgrade to upgrade packages and tools by @jdx in
[#14433](#14433)
- **(env)** add --paths to list the PATH entries mise manages by @jdx in
[#14429](#14429)
- **(install)** download pinned versions from mise.jdx.dev with GitHub
fallback by @jdx in [#14446](#14446)

### 🐛 Bug Fixes

- **(aqua)** read GitHub-hosted aqua registries from
raw.githubusercontent.com by @jdx in
[#14470](#14470)
- **(backend)** build packslip after versions_host_applies was removed
by @jdx in
[8bdf9ae](8bdf9ae)
- **(backend)** resolve packslip prefixes like `latest` by @jdx in
[#14467](#14467)
- **(bootstrap)** render incoming direction for ufw interface rules by
@jdx in [#14480](#14480)
- **(dotfiles)** show planned file actions before the apply prompt by
@jdx in [#14430](#14430)
- **(dotfiles)** speed up flaky objects_at test by @jdx in
[#14439](#14439)
- **(dotfiles)** capture changed files of copy-mode groups with dot add
--changed by @jdx in [#14436](#14436)
- **(exec)** ask mise-versions for GitHub releases when auto-installing
from exec and shims by @jdx in
[#14458](#14458)
- **(github)** stop falling back to api.github.com when mise-versions
misses by @jdx in [#14460](#14460)
- **(github)** read the checksum-mismatch hint's digest from
mise-versions by @jdx in
[#14481](#14481)
- **(github)** list git tags from mise-versions instead of
api.github.com by @jdx in
[#14461](#14461)
- **(github)** verify attestations from mise-versions without
api.github.com fallbacks by @jdx in
[#14469](#14469)
- **(lock)** ignore the host's implicit compile default for other lock
platforms by @jdx in [#14432](#14432)
- **(lock)** download artifacts for provenance checks from github.com,
not the API by @jdx in [#14465](#14465)
- **(oci)** require root for apt bootstrap packages and show dpkg output
on failure by @jdx in [#14447](#14447)
- **(pipx)** preserve uv graph locking during global upgrades by
@wislertt in [#14426](#14426)
- **(ruby)** look up the latest ruby-build release through mise-versions
by @jdx in [#14471](#14471)
- **(self-update)** read mise releases from mise-versions and download
from github.com by @jdx in
[#14464](#14464)
- **(shim)** allow a few repeated fallback handoffs in one process by
@jdx in [#14475](#14475)
- **(upgrade)** leave lazy tools that are not installed to their first
run by @ryanrhughes in [#14422](#14422)
- **(upgrade)** skip version lookups for lazy tools a bare upgrade
leaves alone by @jdx in [#14444](#14444)
- avoid false "stack limit reached" on musl builds by @jdx in
[#14450](#14450)

### 📚 Documentation

- recommend committing mise.lock so CI and Docker skip version lookups
by @jdx in [#14453](#14453)

### ⚡ Performance

- **(backend)** take release tags from the versions host instead of
listing or guessing them by @jdx in
[#14442](#14442)
- **(backend)** read the registry tool's version list for an explicit
backend arg by @jdx in [#14459](#14459)
- **(backend)** stop re-downloading what packslip resolution already
verified by @jdx in [#14466](#14466)
- **(github)** reuse mirrored attestations and skip mise-versions for
asset-less latest releases by @jdx in
[#14443](#14443)
- **(github)** list releases and tags from mise-versions' whole lists by
@jdx in [#14477](#14477)
- **(install)** skip refetching version lists a cached copy already
answers by @jdx in [#14457](#14457)
- **(install)** reuse cached version lists for the tool's release-age
window by @jdx in [#14484](#14484)
- **(install)** keep the versions index and pipx's latest release for
the release-age window by @jdx in
[#14485](#14485)
- **(outdated)** resolve `latest` without refetching the version list by
@jdx in [#14456](#14456)
- **(outdated)** resolve many registry tools with one request to the
mise-versions index by @jdx in
[#14473](#14473)
- **(python)** list python versions from mise-versions instead of
cloning pyenv by @jdx in
[#14455](#14455)
- **(versions-host)** send install tracking and python lists to static
assets by @jdx in [#14441](#14441)

### 📦️ Dependency Updates

- bump jactionlint to 2.2.0 and mbx to 1.24.0 by @jdx in
[#14448](#14448)

### 📦 Registry

- install native-sdk from npm so the native command works by @jdx in
[#14431](#14431)
- add gdal (conda:libgdal-core) by @ivan-ivkovic in
[#14440](#14440)

### Ci

- prune unused release folders from the mise.jdx.dev CDN bucket by @jdx
in [#14445](#14445)
- check R2 credentials on every prune run by @jdx in
[#14451](#14451)
- stop aube-lock from re-committing on Cargo-only Renovate PRs by @jdx
in [#14482](#14482)

### Security

- **(deps)** update rustls to 0.23.46 by @jdx in
[#14434](#14434)
- **(task)** require trust before rendering a remote task file by
@JamBalaya56562 in [#14416](#14416)

### New Contributors

- @ivan-ivkovic made their first contribution in
[#14440](#14440)

## 📦 Aqua Registry Updates

### New Packages (2)

- [`btwld/fvm`](https://github.com/btwld/fvm)
- [`tailscale/tailcat`](https://github.com/tailscale/tailcat)

### Updated Packages (1)

- [`k1LoW/tbls`](https://github.com/k1LoW/tbls)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant