superseded by merged #167: executor regression evidence retained by LIghtJUNction · Pull Request #169 · TokenNotIncluded/msg

LIghtJUNction · 2026-09-28T21:02:27Z

Do not merge this alternative implementation separately

After reviewing #167 at e768cbc and its transferred tests, this work stream agrees to #167 as the single #156/#157 implementation. Do not serially merge two BatchPolicy/factory/decoder designs. #167 includes the neutral packet/schema ownership required by the issue's additional review, and has already retained this PR's independent assembly, batch replay and whole-transaction Event rollback cases.

This PR remains open to preserve source and evidence until that exact integrated replacement passes its complete gates and is merged. It is not a second merge candidate and does not independently close #156. Coordination and the remaining transferred-test correction are recorded in #167 comment5878887706.

Current alternative head and evidence

Head 3db973a, tree 785f3649f9c397891b8bd19c2e56716eaad623bf. It fixes the two failures in the initial implementation without weakening the old webhook test: compare the complete wire representation of frozen JSON, and resolve the installed Event callback at invocation time rather than capturing it early.

RED1953beeda08cb34570f2c56535c4e4b1249546eb / tree28cd98e8d3cb1e54df9714efc29ea06a41107898: cloud36481661656, independently verified 9 failed /25 passed /0 errors /0 skipped, all new boundary tests.
First implementation f7f8a89: cloud36483396339, 2 failed /32 passed. The failures were complete frozen-JSON equality and the original post-load domain-webhook failure injection. Artifact10997282312 SHA-256 d726cd26b800c6415ef7f0edc8c94f5a39f7509036fa66c8590f0cf9d79c26ca was checked.
Corrected3db cloud: architecture/tool36484427128 succeeded; executor36484427064 was executing its tests at the latest read; full36484427130 and recovery36484427030 require final inspection. No combined GREEN claim here.

Replacement review

#167's core.packet has one built-in neutral decoder; a missing optional decoder is therefore not part of its design and must not be artificially introduced to satisfy this alternative API. Existing signature, byte-limit, secret-delivery exclusion, missing-projection refusal and transaction tests remain necessary. No original behavioral assertion is waived.

The transferred standalone test in #167 still uses f7's direct list-vs-frozen-sequence comparison. The exact correction from3db is assert wire(result.data) == {'original': True, 'projection': [{'id': 'r_test'}]}; this was reported with source and cloud evidence, not silently ignored.

Prerequisite #165 has been merged as08c58928ee3f6c6cb350d9e9fba75d072bd78f08 and #160 closed after exact-tree verification. This PR must not replace its ToolRunner/ToolResult contract. Persistent notes: docs/EXECUTOR_PROGRESS_20260929.md and docs/ARCHITECTURE_PROGRESS_20260929.md. All execution/tests were cloud-only. No production, money, Root/PIN, retirement or recovery promotion. Refs #156 #83 #85.

Refs #160 #82 #83 #85. Record source-bound CI evidence and an independent progress note before changing implementation.

…-neutral Keep publication, current authorization and lease fences in EffectWorker; preserve the effects.ToolResult export and explicitly retire the unused ToolExecutor.invoke declaration. Refs #160 #82 #85.

Refs #156 #83 #85. Run independent assembly and existing transaction/security regressions in cloud before changing implementation.

Record exact parent and nine allowed source paths; no force update, no test or production execution with write credentials. Subsequent PR CI verifies the generated source independently.

Refs #156 #83 #85. Preserve the existing transaction, authentication and secret-delivery paths.

…mentation Refs #156 #160 #83 #85. Keep final-head full verification and production acceptance explicitly pending.

Copilot

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

chatgpt-codex-connector · 2026-09-28T21:02:37Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
🔒 Security Review	✅ Completed 2026-09-28T21:07:28.972747Z	`f7f8a89`	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

…JSON correctly Cloud run36483396339 exposed 2 failures; retain the old webhook fault-injection/rollback test unchanged and fix the assembly binding. The new standalone test compares the complete wire value, not list against frozen tuple. Refs #156 #83 #85.

LIghtJUNction · 2026-09-28T21:12:16Z

已对照本PR和tests/test_executor_boundary.py，与#167的#156修复重复。建议不要把make_executor/BatchPolicy与new_executor/core.batching两套执行内核串行合入。#167还完成了#156第二轮补充要求的公共packet/schema中立所有权，core导入链在禁用plugins/transports/application时可独立加载，旧wire/schema路径为同对象别名，不需要再注入一个缺省为空的decoder。

本PR的显式独立装配、工厂批处理/回放、事件通知失败整事务回滚用例有价值，我将把这些断言移植到#167的唯一接口上，保留失败必须不提交的语义。missing decoder用例属于本PR新增的可选依赖设计；#167使用唯一内置中立codec，不存在缺失decoder配置，将以完整批处理签名/限长/秘密排除回归覆盖该路径，不伪造同名错误。

#165工具修复仍保持独立，不从本PR重复合入。不会改写本PR分支；在唯一组合实现通过全量和专项后再处理重复PR状态。已在#83评论5878614115记录协调。

… repairs Refs #156 #157 #166 #169 #83. Keep all 16 metadata contracts and three independent assembly/rollback cases on the single integrated implementation; extend existing cloud suites without changing production code or weakening assertions.

…ementation Integrate #166 b0ec3fc without replacing canonical executor/storage source. Preserve its original parity tests, historical evidence and workflow, and include its full regression selection in the current focused gate. Adapt #169's corrected complete wire-value assertion for immutable JSON. Refs #156 #157 #83 #85.

… implementation Combine #171 client5f56bbe4 with #167 e768cbc without changing either other work stream's ref. Retain #167 executor, packet/schema, QuerySession/RelationalSession and all regression tests; retain merged #165 tool contract. Core codec owns the one result_wire function; packet re-exports that same object and executor keeps its packet import. Preserve all client helper, installation and signature tests. Apply the complete frozen-JSON comparison correction from #169 3db973a, whose 34 focused regressions passed in cloud. Refs #158 #156 #157 #83 #85. Final combined tree requires new full/focused cloud gates; no historical GREEN or production acceptance is claimed.

LIghtJUNction · 2026-09-29T10:04:12Z

满足本PR正文约定的替代关闭条件：#167已于2026-09-29T08:58:23Z合入main261c8816cd581deaf69fc0c810b8fa6dad5ead5e/tree6171f6041ffd0addaf72eadd35acf562f478281f。

已实际读取合入的test_execution_composition.py，保留3个独立装配/批处理回放/通知失败整事务回滚用例，且完整投影断言已是wire(result.data)。三个node均在完整CI36486040116的已执行集合内，不是只保留了文件。

本次独立下载4份JUnit/清单，核验SHA256与精确node-ID互斥全集：1,894/1,894通过，0失败/错误/跳过；另8conformance、构建和contracts gate通过。合并后main36546119029及恢复36546118849成功。完整散列与来源：#167 comment5887987237；#156验收：comment5887991546，现已completed关闭。

因此将本PR关闭为superseded，不合入第二套BatchPolicy/factory/decoder，不删历史源分支、红基线或回归证据。#165工具契约未回退；#85等总体验收仍独立。

LIghtJUNction and others added 6 commits September 29, 2026 04:41

test(architecture): expose runner port drift with cloud regressions

b553c59

Refs #160 #82 #83 #85. Record source-bound CI evidence and an independent progress note before changing implementation.

refactor(tools): make the actual runner port and local result backend…

f14fd15

…-neutral Keep publication, current authorization and lease fences in EffectWorker; preserve the effects.ToolResult export and explicitly retire the unused ToolExecutor.invoke declaration. Refs #160 #82 #85.

test(core): expose executor composition and plugin dependency debt

1953bee

Refs #156 #83 #85. Run independent assembly and existing transaction/security regressions in cloud before changing implementation.

ci(core): apply the reviewed executor patch on the isolated cloud branch

9b45cfa

Record exact parent and nine allowed source paths; no force update, no test or production execution with write credentials. Subsequent PR CI verifies the generated source independently.

refactor(core): inject bounded executor services at the composition root

c639a52

Refs #156 #83 #85. Preserve the existing transaction, authentication and secret-delivery paths.

docs(core): record verified RED evidence and the exact executor imple…

f7f8a89

…mentation Refs #156 #160 #83 #85. Keep final-head full verification and production acceptance explicitly pending.

Copilot AI lite review requested due to automatic review settings September 28, 2026 21:02

Copilot AI reviewed Sep 28, 2026

This was referenced Sep 28, 2026

[P2] Registry/规则源/配置与第15章逐项验收矩阵 #83

Closed

refactor(tools): neutral runner contract with cloud regression evidence #165

Merged

LIghtJUNction changed the title ~~refactor(core): explicit executor services without plugin backreferences~~ Alternative executor implementation — regressions consolidating into #167 Sep 28, 2026

This was referenced Sep 28, 2026

refactor(git): isolate HTTP adapters and share guarded publication #170

Merged

refactor(client): minimal client install and neutral shared protocol helpers #171

Merged

LIghtJUNction changed the title ~~Alternative executor implementation — regressions consolidating into #167~~ superseded by merged #167: executor regression evidence retained Sep 29, 2026

LIghtJUNction closed this Sep 29, 2026

Navigation Menu

Repository navigation

superseded by merged #167: executor regression evidence retained - #169

superseded by merged #167: executor regression evidence retained#169
LIghtJUNction wants to merge 7 commits into
mainfrom
fix/executor-boundary-20260929

LIghtJUNction commented Sep 28, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

chatgpt-codex-connector Bot commented Sep 28, 2026 •

edited

Loading

Uh oh!

LIghtJUNction commented Sep 28, 2026

Uh oh!

LIghtJUNction commented Sep 29, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

LIghtJUNction commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Do not merge this alternative implementation separately

Current alternative head and evidence

Replacement review

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

chatgpt-codex-connector Bot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

LIghtJUNction commented Sep 28, 2026

Uh oh!

LIghtJUNction commented Sep 29, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

LIghtJUNction commented Sep 28, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Sep 28, 2026 •

edited

Loading