Repository navigation
refactor(tools): neutral runner contract with cloud regression evidence - #165
Merged
Merged
Conversation
4 tasks
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Sep 28, 2026
LIghtJUNction
added a commit
that referenced
this pull request
Sep 28, 2026
… implementation Combine #171 client5f56bbe4 with #167 e768cbc without changing either other work stream's ref. Retain #167 executor, packet/schema, QuerySession/RelationalSession and all regression tests; retain merged #165 tool contract. Core codec owns the one result_wire function; packet re-exports that same object and executor keeps its packet import. Preserve all client helper, installation and signature tests. Apply the complete frozen-JSON comparison correction from #169 3db973a, whose 34 focused regressions passed in cloud. Refs #158 #156 #157 #83 #85. Final combined tree requires new full/focused cloud gates; no historical GREEN or production acceptance is claimed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Fixes #160. Refs #82 #83 #85; no umbrella issue or production acceptance is complete.
core.tool_executionowns the actual asynchronous callable ToolRunner and local-artifact ToolResult. EffectWorker and BubblewrapRunner use the same contract. Sandbox no longer imports the worker implementation.effects.ToolResultstays the identical class; the unused ToolExecutor.invoke-to-ResourceRef declaration is explicitly retired with an import alias to the actual runner port.Existing local output validation, publication transaction, current authorization, mandatory isolation, quarantine and attempt/state/deadline fences are unchanged. Returning an existing ResourceRef from an injected runner is tested to produce no published output. No production action.
Verified RED → GREEN
RED
b553c59b484a4e5a383df3500ad9e4cab9d51272, tree59fadd97fb38f4dc60a21cb4dfb0535f913ef808: run36480982432 7 failed / 31 passed. All failures were new boundary tests; old tool and completion-fence regressions passed.Final head f14fd15, tree 8a62150d8273a2c75775872694749cb529835966, tested as merge 0af4b19 onto main 476e64f. Refreshed PR metadata still reports that head/base/merge and mergeable=true.
Full artifact IDs/hash: 10997336115=
5e5d2739a19d3ce1282d3baa00f1361f77763cb5c4e82e40d29bf504e010ec19; 10997431290=034e4b8423ec78681c6d8c371a9e2b3a77433ba48de1a16f79821f9eeb1f3ee4; 10996419745=b60449dc9578633afc64aaa1f114924e1a50c45cc06790b3ac45bd2e8e44b7af; 10997176225=36a5eb7760b4c2c0c19fd7f4976e107622fae5f136d731c9e757ca5816f11da0.Reviewed the full final diff: expected neutral types/annotations/compatibility export, unchanged worker logic (one incidental whitespace-only market-mail hunk), new tests/docs and focused workflow. Codex security review completed for f14fd15 without posted findings; Copilot could not review because of quota and is not counted as approval. No existing assertions or full CI gates were weakened.
Persistent notes: docs/ARCHITECTURE_PROGRESS_20260929.md (initial checkpoint; updated continuation in #169), docs/TOOL_RUNNER_BOUNDARY.md. All project execution/tests ran in cloud; local work was source inspection/editing and artifact verification. #155/#166 branches were not changed.