Skip to content

test(storage): extend backend parity coverage for the shared-session refactor - #166

Merged
LIghtJUNction merged 6 commits into
fix/executor-core-20260929-2045from
fix/metadata-session-boundary-20260929
Sep 28, 2026
Merged

LIghtJUNction merged 6 commits into
fix/executor-core-20260929-2045from
fix/metadata-session-boundary-20260929

Conversation

@LIghtJUNction

@LIghtJUNction LIghtJUNction commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Converged scope: supplemental tests stacked on #167

Refs #157 #83 #85. Current head b0ec3fc, tree 765b569ba3508019eda1cf85161a335ffcea508f.

To avoid two competing storage implementations, this PR now adopts #167 source a85b744 unchanged and adds only the existing 16 independent backend-parity tests, their focused cloud workflow, and docs/METADATA_SESSION_PROGRESS.md. It is retargeted to #167's branch. The old and adopted histories are preserved by a non-force two-parent commit.

The tests retain all assertions. Only four references to the neutral base name are aligned to #167's canonical RelationalSession. The adopted implementation supplies the explicit QuerySession/QueryResult port, transaction-lifetime result guards and missing declared domain methods; this is not a second base, query wrapper or database service. No upstream branch or main was overwritten.

Preserved evidence (old source, not new-head certification)

  • Red 36481798533, exact7f8752e / tree686dbdd: 4 failed, 12 passed, 0 errors/skips; all failures were new architecture assertions.
  • Original exact implementation0ef416ec / treead1d3f4: focused 36483460243 16 new +80 existing =96 passed, 0 failures/errors/skips. Both JUnit/source files read; artifact10997317418 SHA256 verified 8a9cc70e9c31d19baf18050f42eda11818786d671863ded05d35b5e9ab098354.
  • The original 42-method/Store/schema/driver AST audit and source hashes remain in the progress note; its parallel implementation is superseded, not separately merged.

Current gate

The new combined source must pass focused, complete four-shard exact node-ID, conformance/build and Recovery safety again. No green result is yet claimed for b0ec3fc. #167 and #169 also overlap on the executor and must converge before main integration; #165 has already moved main to08c58928. Do not treat old-head or parent passes as combined-head evidence.

Tests cover independent PostgreSQL import, neutral ownership, actual declared contract, both database adapters' resource versions/path/paging, result/event/audit/job identities, rollback/savepoints, read-only/closed/cross-task guards, constraint rollback and SQL literals. Existing PostgreSQL lock/concurrency, ledger migration and recovery regressions remain.

No production, Root/PIN, real funds/outbound effects, schema migration, backup destruction or restore promotion. Umbrella/production-evidence issues stay open.

@LIghtJUNction
LIghtJUNction marked this pull request as ready for review September 28, 2026 21:10
Copilot AI lite review requested due to automatic review settings September 28, 2026 21:10

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
🔒 Security Review ✅ Completed 2026-09-28T21:15:20.449234Z 0ef416e Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Contributor Author

已对照本PR源码与tests/test_metadata_session_boundary.py。与 #167 的 #157 实现重复,建议收敛为一个存储基类,不串行引入 MetadataSessionBase/RelationalSession 两套定义。

本PR的12个双后端行为回归覆盖资源代际/路径/分页、result/event/audit/job、补偿范围、只读/跨任务/关闭、冲突回滚、占位符,均有独立价值;本会话将保留这些行为断言到#167的组合验收。四个结构断言也将按唯一最终类型保留,不通过删除断言掩盖回归。

#157追加评论要求的实际查询接口缺口不能把one/rows/path/job等称为storage-local就忽略:market.policy等真实消费者仍调用。#167同时补QuerySession、五个域方法声明和受会话生命周期约束的查询结果。当前a85b744/tree042422的存储专项36483874055已success,完整结果尚待验证。

不改写本PR源分支,保留原red/assembly证据;待合并唯一实现并完成组合回归后再关闭重复PR,不现在宣称#157全验收完成。

LIghtJUNction added a commit that referenced this pull request Sep 28, 2026
… repairs

Refs #156 #157 #166 #169 #83. Keep all 16 metadata contracts and three independent assembly/rollback cases on the single integrated implementation; extend existing cloud suites without changing production code or weakening assertions.
@LIghtJUNction LIghtJUNction changed the title refactor: separate metadata session invariants from database adapters test(storage): extend backend parity coverage for the shared-session refactor Sep 28, 2026
@LIghtJUNction
LIghtJUNction changed the base branch from main to fix/executor-core-20260929-2045 September 28, 2026 21:16
@LIghtJUNction
LIghtJUNction merged commit 2d1cc44 into fix/executor-core-20260929-2045 Sep 28, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants