Repository navigation
fix(engine): report generic test classes by their generic type definition in TRX #7200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| using Shouldly; | ||
| using TUnit.Engine.Tests.Enums; | ||
|
|
||
| namespace TUnit.Engine.Tests; | ||
|
|
||
| /// <summary> | ||
| /// The TRX className of a test on a generic class is the generic type definition's full name | ||
| /// (<c>Ns.Class`1</c>) in both modes, so every instantiation groups under one class (#7151). | ||
| /// Reflection mode used to report the closed type with assembly-qualified type arguments. | ||
| /// </summary> | ||
| public class Issue7151Tests(TestMode testMode) : InvokableTestBase(testMode) | ||
| { | ||
| [Test] | ||
| [Arguments("GenericClassSameTypeRows", 3)] | ||
| [Arguments("GenericClassMixedTypeRows", 4)] | ||
| [Arguments("GenericClassMixedTypeMethodRows", 3)] | ||
| [Arguments("GenerateGenericTestWithMethodRows", 2)] | ||
| public async Task Generic_Class_Trx_ClassName_Is_The_Generic_Type_Definition(string className, int expectedTests) | ||
| { | ||
| await RunTestsWithFilter( | ||
| $"/*/TUnit.TestProject.Bugs._7106/{className}/*", | ||
| [ | ||
| result => result.ResultSummary.Outcome.ShouldBe("Completed"), | ||
| result => result.ResultSummary.Counters.Passed.ShouldBe(expectedTests), | ||
| result => result.TestDefinitions.Select(x => x.TestMethod.ClassName).Distinct().ToArray() | ||
| .ShouldBe(new[] { $"TUnit.TestProject.Bugs._7106.{className}`1" }) | ||
|
thomhurst marked this conversation as resolved.
Resolved
|
||
| ]); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,34 @@ | ||
| using TUnit.Engine.Extensions; | ||
|
|
||
| namespace TUnit.UnitTests; | ||
|
|
||
| /// <summary> | ||
| /// The class name reported for a test (TRX className and the JSON model's ClassType) is the generic | ||
| /// type definition's full name, so reflection mode's closed types report the same name as | ||
| /// source-generated mode's open ones (#7151). | ||
| /// </summary> | ||
| public class ReportedClassFullNameTests | ||
| { | ||
| [Test] | ||
| public async Task Closed_Generic_Type_Reports_Its_Generic_Type_Definition() | ||
| { | ||
| await Assert.That(TestExtensions.GetReportedClassFullName(typeof(Holder<int>))) | ||
| .IsEqualTo("TUnit.UnitTests.ReportedClassFullNameTests+Holder`1"); | ||
| } | ||
|
|
||
| [Test] | ||
| public async Task Open_Generic_Type_Reports_Its_Full_Name() | ||
| { | ||
| await Assert.That(TestExtensions.GetReportedClassFullName(typeof(Holder<>))) | ||
| .IsEqualTo("TUnit.UnitTests.ReportedClassFullNameTests+Holder`1"); | ||
| } | ||
|
|
||
| [Test] | ||
| public async Task Non_Generic_Type_Reports_Its_Full_Name() | ||
| { | ||
| await Assert.That(TestExtensions.GetReportedClassFullName(typeof(ReportedClassFullNameTests))) | ||
| .IsEqualTo("TUnit.UnitTests.ReportedClassFullNameTests"); | ||
| } | ||
|
|
||
| private sealed class Holder<T>; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.