Repository navigation
Remove pre-1.0 compatibility shims - #222
Conversation
GitHub Actions
Failure
|
Warning Review limit reached
Next review available in: 18 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe PR removes obsolete string command overloads and configuration aliases. It changes ChangesAPI hygiene
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Comment |
🧪 Integration Test Results (net10.0)ℹ️ Execution Details
Automated integration testing with Redis containers using TUnit |
🧪 Integration Test Results (net8.0)ℹ️ Execution Details
Automated integration testing with Redis containers using TUnit |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b17053fe8b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
GitHub Actions
Inactive
🧪 Integration Test Results (net10.0)ℹ️ Execution Details
Automated integration testing with Redis containers using TUnit |
🧪 Integration Test Results (net8.0)ℹ️ Execution Details
Automated integration testing with Redis containers using TUnit |
There was a problem hiding this comment.
💡 Codex Review
Respire/src/Respire/RespireOptions.cs
Line 112 in af3587e
Update the Sentinel guide before removing ServiceName
With this alias gone, the published Sentinel example in website/docs/fundamentals/connections.md:112-123 still initializes ServiceName, so readers compiling that example against this revision receive CS0117 instead of a working client. Migrate that example to SentinelPrimaryName as part of this removal.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
af3587e to
3cb891e
Compare
|
Addressed the latest review-body finding in 3cb891e: the Sentinel guide now uses SentinelPrimaryName. Also rebased onto #223 while preserving its safe interpolated fire-and-forget overload. Validation: Respire.Tests 551 passed; caching tests 76 passed; Docusaurus build passed; benchmark project builds net8/net10. |
GitHub Actions
Inactive
🧪 Integration Test Results (net10.0)ℹ️ Execution Details
Automated integration testing with Redis containers using TUnit |
🧪 Integration Test Results (net8.0)ℹ️ Execution Details
Automated integration testing with Redis containers using TUnit |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3cb891ed2c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
CI triage: |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@website/docs/fundamentals/connections.md`:
- Line 119: Update the sentence preceding the Sentinel configuration example to
reference SentinelPrimaryName instead of the removed ServiceName property,
keeping the surrounding documentation unchanged.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: 664005f6-9713-49f5-870c-7a3eaeae9352
📒 Files selected for processing (18)
benchmarks/Respire.Benchmarks/CommandRoutingBenchmarks.cssrc/Respire.Extensions.DependencyInjection/RespireOptionsBuilder.cssrc/Respire/IRespireClient.cssrc/Respire/RespireClient.cssrc/Respire/RespireCommandFlags.cssrc/Respire/RespireOptions.cstests/Respire.Extensions.Caching.Tests/RespireDistributedCacheTests.cstests/Respire.Extensions.Caching.Tests/ServiceCollectionTests.cstests/Respire.Tests/ExceptionErgonomicsTests.cstests/Respire.Tests/Networking/ClientCoreTests.cstests/Respire.Tests/Networking/ClusterTests.cstests/Respire.Tests/Networking/CollectionScanTests.cstests/Respire.Tests/Networking/CommandCatalogTests.cstests/Respire.Tests/Networking/RespireConnectionTests.cstests/Respire.Tests/Networking/SentinelTests.cstests/Respire.Tests/RespireOptionsTests.cstests/Respire.Tests/TelemetryTests.cswebsite/docs/fundamentals/connections.md
💤 Files with no reviewable changes (5)
- tests/Respire.Extensions.Caching.Tests/RespireDistributedCacheTests.cs
- src/Respire/RespireOptions.cs
- src/Respire/RespireClient.cs
- src/Respire/IRespireClient.cs
- src/Respire.Extensions.DependencyInjection/RespireOptionsBuilder.cs
|
The failed net8 build job hit unrelated pub/sub timing drift: |
GitHub Actions
Inactive
🧪 Integration Test Results (net10.0)ℹ️ Execution Details
Automated integration testing with Redis containers using TUnit |
There was a problem hiding this comment.
💡 Codex Review
Respire/src/Respire/RespireOptions.cs
Line 101 in ec9d6ca
Update the packaged cluster example to UseCluster
When users copy the Redis Cluster example from the packaged README (README.md:194-203), it still initializes Cluster = true; after this alias is removed, that example no longer compiles. Because Directory.Build.props includes this README in every package, update the example to use UseCluster in the same change or ensure the documented dependency lands first.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
🧪 Integration Test Results (net8.0)ℹ️ Execution Details
Automated integration testing with Redis containers using TUnit |
Summary
RespireOptionsand DI builder compatibility aliasesIRespireClientandRespireClientRespireCommandFlags.NoRedirectto bit 0Test plan
Respire.Tests(550passed)Respire.Extensions.Caching.Tests(76passed)dotnet build Respire.slnx -c Release(local agent guard stopped at 3072 MB after core projects compiled; CI will run full build)Dependency
README alias cleanup is in #221. Issue #216 is linked as blocked by #218 to preserve merge order.
Closes #216
Summary by CodeRabbit
Breaking Changes
NoRedirectflag value for consistency.Documentation
Tests