Repository navigation
dmic: switch to use uncached dmic_prm[] - #4196
Merged
Merged
Conversation
Collaborator
|
verified on one TGLU NOCODEC RVP device |
singalsu
approved these changes
May 17, 2021
singalsu
left a comment
singalsu
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, thanks Keyon!
Contributor
Author
|
looks it lead to some regression on APL platforms, let me debug it. |
keyonjie
marked this pull request as draft
May 17, 2021 08:10
Member
|
@keyonjie looks like this is failing on unrelated tests ? |
When multi-core introduced, we need to use uncached address for the global configuration variables, to make sure they are consistent for all DSP cores. When variables change, write through for both cached and uncached addresses, to ensure the consistency. Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
keyonjie
marked this pull request as ready for review
May 17, 2021 09:06
Contributor
Author
It is actually :), looks there is no write back mechanism on APL, now I change the PR to do write through when dmic_prm[] is changing and the APL works now at my end. Let's wait for the PR validation result. |
aiChaoSONG
approved these changes
May 17, 2021
Contributor
Author
|
looks good now @lgirdwood |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When multi-core introduced, we need to use uncached address for the
global configuration variables, to make sure they are consistent for all
DSP cores.
Signed-off-by: Keyon Jie yang.jie@linux.intel.com