Repository navigation
drivers: Intel: dmic: make DMIC prm and active fifo count shared - #4195
Merged
Merged
Conversation
ranj063
force-pushed
the
fix/dmic_shared
branch
2 times, most recently
from
May 14, 2021 22:33
a8fcd5f to
f2e73dc
Compare
When the DMIC pipeline is moved to a core other than the primary core, the DMIC params and dmic_active_fifos are not valid. Modify them to be shared data and handle cache management when accessing/modifying them. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
lgirdwood
approved these changes
May 16, 2021
Member
|
@ranj063 good find, I'll cherry-pick for rc2 |
Contributor
|
Hi @ranj063 we are still seeing DSP panic with this, looks we need to use uncached mode of dmic_prm[] also. |
Contributor
|
@ranj063 @lgirdwood one more change needed per my observation: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the DMIC pipeline is moved to a core other than the
primary code, the DMIC params and dmic_active_fifos are
not valid. Modify them to be shared data and handle
cache management when accessing/modifying them.
Signed-off-by: Ranjani Sridharan ranjani.sridharan@linux.intel.com