Skip to content

ipc: align stream.h with kernel #1592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jajanusz merged 2 commits into from
Jul 24, 2019
Merged

ipc: align stream.h with kernel #1592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e403ac0
ipc: align stream.h with kernel
mrajwa Jun 26, 2019
368e63f
host: fix wrong check for irq
mrajwa Jun 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/audio/host.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,8 +107,8 @@ static void host_update_position(struct comp_dev *dev, uint32_t bytes)
if (hd->local_pos >= hd->host_size)
hd->local_pos = 0;

/* NO_IRQ mode if host_period_size == 0 */
if (dev->params.host_period_bytes != 0) {
/* NO_IRQ mode if no_period_irq == 1 */
if (!dev->params.no_period_irq) {
hd->report_pos += bytes;

/* send IPC message to driver if needed */
Expand Down
4 changes: 2 additions & 2 deletions src/include/ipc/stream.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,10 +90,10 @@ struct sof_ipc_stream_params {
uint16_t sample_valid_bytes;
uint16_t sample_container_bytes;

/* for notifying host period has completed - 0 means no period IRQ */
uint32_t host_period_bytes;
uint16_t no_period_irq; /* 1 means period IRQ mode OFF */

uint32_t reserved[2];
uint16_t reserved[3];

@plbossart plbossart Jun 28, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you also have a comment that needs to be fixed line 93 and in general it helps when you add more details on a boolean. in other places we use no_irq, here it's period_irq so 50% of people will get it wrong :-)

@lgirdwood lgirdwood Jul 3, 2019

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrajwa is this now resolved ? We can merge if resolved.

@mrajwa mrajwa Jul 9, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgirdwood yes I think we can merge both sides simultaneously.

uint16_t chmap[SOF_IPC_MAX_CHANNELS]; /**< channel map - SOF_CHMAP_ */
} __attribute__((packed));

Expand Down