Repository navigation
ipc: align stream.h with kernel - #1592
Merged
Merged
Conversation
mrajwa
requested review from
a team,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
June 26, 2019 23:36
tlauda
reviewed
Jun 27, 2019
Contributor
There was a problem hiding this comment.
It will look nicer if we merge them together.
Contributor
Author
There was a problem hiding this comment.
Sure I can define reserved as uint16_t and make it uint16_t reserved[3]; then remove not_used competely.
plbossart
reviewed
Jun 27, 2019
plbossart
previously requested changes
Jun 28, 2019
Member
There was a problem hiding this comment.
you also have a comment that needs to be fixed line 93 and in general it helps when you add more details on a boolean. in other places we use no_irq, here it's period_irq so 50% of people will get it wrong :-)
Member
There was a problem hiding this comment.
@mrajwa is this now resolved ? We can merge if resolved.
Contributor
Author
There was a problem hiding this comment.
@lgirdwood yes I think we can merge both sides simultaneously.
keyonjie
reviewed
Jun 28, 2019
keyonjie
reviewed
Jun 28, 2019
keyonjie
reviewed
Jun 28, 2019
This change is to align sof_ipc_stream_params with its kernel equivalent. The change is needed in both kernel and FW because FW needs to use host_period_bytes which where previously used to inform host about period IRQ. Therefore now we introduce new member for it period_irq and let host_period_bytes keep the proper value. Signed-off-by: Marcin Rajwa <marcin.rajwa@linux.intel.com>
This patch fixes the incorrect check of period irq in host_period_bytes. Signed-off-by: Marcin Rajwa <marcin.rajwa@linux.intel.com>
lgirdwood
approved these changes
Jun 30, 2019
jajanusz
approved these changes
Jul 1, 2019
tlauda
approved these changes
Jul 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change is to align sof_ipc_stream_params with its
kernel equivalent. The change is needed in both kernel
and FW because FW needs to use host_period_bytes which
where previously used to inform host about period IRQ.
Therefore now we introduce new member for it period_irq
and let host_period_bytes keep the proper value.
Corresponding Kernel PR is here thesofproject/linux#1037