Repository navigation
Conversation
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
==========================================
+ Coverage 84.94% 85.13% +0.18%
==========================================
Files 19 19
Lines 392 397 +5
Branches 25 26 +1
==========================================
+ Hits 333 338 +5
Misses 43 43
Partials 16 16
Continue to review full report at Codecov.
|
|
@tillahoffmann , would you like to review? |
|
|
||
|
|
||
| def test_can_build_images_before_spawning_service_via_compose(): | ||
| with DockerCompose(TESTS_DIR, build=True) as compose: |
There was a problem hiding this comment.
What does docker-compose do when --build is passed but the docker-compose.yml file doesn't contain any reference to a locally-built image?
There was a problem hiding this comment.
Good question!
I just tried it with the tests/docker-compose.yml and it had no effect; it worked exactly as it would without it.
|
Closing for now as This is a bit of a tricky one: it's somewhat easier to argue for supporting |
This PR adds support to build the containers before starting the services.
Resolves #76
Also, there's an enhancement to the tests to make them run from anywhere, it doesn't have to be project root. This was an issue when running the tests from an IDE, like PyCharm.