Skip to content

Option to build the docker containers before starting #76

Closed

Description

@jtanios

When using this package to test a custom container, it'd be good to build the containers before starting the service every time the test runs to make sure any new changes to the Dockerfiles are tested.

I think this can be a param to the DockerCompose constructor:
def __init__(self, filepath, compose_file_name="docker-compose.yml", build=False):

If True, it would add a --build option to the docker-compose command inside start()

Activity

  1. tillahoffmann commented on Mar 22, 2020

    @tillahoffmann
    Contributor

    That sounds like a good idea. Fancy sending a PR?

  2. jtanios commented on Mar 23, 2020

    @jtanios
    Author

    That sounds like a good idea. Fancy sending a PR?

    Sure, I'll submit one pretty soon.

  3. tillahoffmann commented on Jun 19, 2020

    @tillahoffmann
    Contributor

    Closing for now as wontfix (see #83 for details), but thank you for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions