Skip to content

Support positive hexadecimal values in NumberUtils #37434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbrannen merged 1 commit into from
Oct 10, 2026
Merged

Support positive hexadecimal values in NumberUtils #37434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions spring-core/src/main/java/org/springframework/util/NumberUtils.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,7 +276,7 @@ public static <T extends Number> T parseNumber(
* {@code Integer.valueOf}, etc.
*/
private static boolean isHexNumber(String value) {
int index = (value.startsWith("-") ? 1 : 0);
int index = (value.startsWith("-") || value.startsWith("+") ? 1 : 0);
return (value.startsWith("0x", index) || value.startsWith("0X", index) || value.startsWith("#", index));
}

Expand All @@ -290,9 +290,9 @@ private static BigInteger decodeBigInteger(String value) {
int index = 0;
boolean negative = false;

// Handle minus sign, if present.
if (value.startsWith("-")) {
negative = true;
// Handle sign, if present.
if (value.startsWith("-") || value.startsWith("+")) {
negative = value.startsWith("-");
index++;
}

Expand Down
10 changes: 10 additions & 0 deletions spring-core/src/test/java/org/springframework/util/NumberUtilsTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,6 +117,16 @@ void parseNumberAsHex() {
assertThat(NumberUtils.parseNumber("0x" + aReallyBigInt, BigInteger.class)).as("BigInteger did not parse").isEqualTo(new BigInteger(aReallyBigInt, 16));
}

@Test
void parseNumberAsPositiveHex() {
assertThat(NumberUtils.parseNumber("+0x7f", Byte.class)).isEqualTo((byte) 127);
assertThat(NumberUtils.parseNumber("+0X7fff", Short.class)).isEqualTo((short) 32767);
assertThat(NumberUtils.parseNumber("+#2a", Integer.class)).isEqualTo(42);
assertThat(NumberUtils.parseNumber("+0x2a", Long.class)).isEqualTo(42L);
assertThat(NumberUtils.parseNumber("+0xFEBD4E677898DFEBFFEE44", BigInteger.class))
.isEqualTo(new BigInteger("FEBD4E677898DFEBFFEE44", 16));
}

@Test
void parseNumberAsNegativeHex() {
String aByte = "-0x80";
Expand Down