Repository navigation
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
sbrannen
added
the
in: core
Signed-off-by: Esmaeil Chitgar <ec.chitgar@gmail.com>
EsmaeilChitgar
force-pushed
the
fix/numberutils-positive-hex-prefix
branch
from
October 10, 2026 04:38
a8f0e8e to
a5a9e73
Compare
sbrannen
changed the title
NumberUtils
sbrannen
added
type: enhancement
sbrannen
approved these changes
Oct 10, 2026
sbrannen
added a commit
that referenced
this pull request
Oct 10, 2026
Member
|
Hi @EsmaeilChitgar, Good catch and congratulations on submitting your first PR for the Spring Framework! 👍 This has been merged into Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR updates
NumberUtils.parseNumber()to support hexadecimal numbers prefixed with a plus sign.Problem
For example:
Previously, this resulted in a
NumberFormatException, despite the corresponding JDK decoding methods accepting this representation.Solution
BigIntegerparsing.Testing
Regression tests have been added to
NumberUtilsTests.The change is intended to preserve existing parsing behavior for other numeric formats.