Repository navigation
tidy: use repository-relative path for style checks - #164681
Merged
Merged
Conversation
rustbot
added
A-tidy
Collaborator
|
|
This comment has been minimized.
This comment has been minimized.
paradoxicalguy
force-pushed
the
tidy-clean-up
branch
from
October 21, 2026 11:46
5fa3835 to
e5130b6
Compare
Contributor
Author
|
blank push to re-run failed job |
Contributor
Author
|
@bors r+ |
Contributor
|
@paradoxicalguy: 🔑 Insufficient privileges: not in review users |
Member
|
Confirmed that it fixes the issue. Thanks. @bors r+ rollup |
Contributor
rust-bors
Bot
added
S-waiting-on-bors
Contributor
Author
|
thank you :D |
JonathanBrouwer
added a commit
to JonathanBrouwer/rust
that referenced
this pull request
Oct 21, 2026
…bzol tidy: use repository-relative path for style checks fixes rust-lang#164567 when `remap-debuginfo = true`, `file!()` returns a remapped path that doesn't match the filesystem path used by tidy. this prevents tidy from recognizing `style.rs` as its own implementation, causing it to report style violations within the file. **use a repository-relative path instead, consistent with the existing handling of codegen.rs.** r? @Kobzol cc @Urgau
This was referenced Oct 21, 2026
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 21, 2026
…uwer Rollup of 13 pull requests Successful merges: - #162460 (Feat - `#[inline(always)] + #[target_feature(enable = "....")]` #2) - #163485 (`rustc_builtin_macros` cleanup, part 8) - #164457 (Add `vec_visualizer` lldb test) - #161253 (Implement `AsMut<T>` and `AsRef<T>` for `!`.) - #162369 (Document the `recursion_limit` built-in attribute) - #162840 (tier 3 target policy: target CPU and features must be supported by upstream backend) - #164329 (use default_field_values in declare_lint) - #164330 (Skip redundant monomorphization checks) - #164527 (doc: added addtional docs for Write) - #164656 (stabilize ExitCodeExt for Windows) - #164660 (Touch up attribute docs) - #164681 (tidy: use repository-relative path for style checks) - #164688 (re-enable test_dir_remove_dir test on QNX)
rust-bors Bot
pushed a commit
that referenced
this pull request
Oct 21, 2026
Rollup merge of #164681 - paradoxicalguy:tidy-clean-up, r=Kobzol tidy: use repository-relative path for style checks fixes #164567 when `remap-debuginfo = true`, `file!()` returns a remapped path that doesn't match the filesystem path used by tidy. this prevents tidy from recognizing `style.rs` as its own implementation, causing it to report style violations within the file. **use a repository-relative path instead, consistent with the existing handling of codegen.rs.** r? @Kobzol cc @Urgau
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #164567
when
remap-debuginfo = true,file!()returns a remapped path that doesn't match the filesystem path used by tidy. this prevents tidy from recognizingstyle.rsas its own implementation, causing it to report style violations within the file.use a repository-relative path instead, consistent with the existing handling of codegen.rs.
r? @Kobzol
cc @Urgau