Skip to content

doc: added addtional docs for Write - #164527

Merged
rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
GauravPawar101:fix/issue-164466
Oct 21, 2026
Merged

rust-bors[bot] merged 1 commit into
rust-lang:mainfrom
GauravPawar101:fix/issue-164466

Conversation

@GauravPawar101

@GauravPawar101 GauravPawar101 commented Oct 18, 2026 •

Copy link
Copy Markdown
Contributor

Changes

  • Added docs for Write with example.

Close #164466

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 18, 2026
@rustbot rustbot added the T-libs Relevant to the library team, which will review and decide on the PR/issue. label Oct 18, 2026
@rustbot

rustbot commented Oct 18, 2026

Copy link
Copy Markdown
Collaborator

r? @JohnTitor

rustbot has assigned @JohnTitor.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Why was this reviewer chosen?

The reviewer was selected based on:

  • Owners of files modified in this PR: libs
  • libs expanded to 12 candidates
  • Random selection from JohnTitor, Mark-Simulacrum

@GauravPawar101

Copy link
Copy Markdown
Contributor Author

Hey, there maintainer. Hope you are doing great. Just hit me up if any suggestions.
:)

Comment thread library/core/src/fmt/mod.rs Outdated
///
/// Writes some formatted information into this instance.
///
/// The formatted output is appended to this formatter's current output;

@JohnTitor JohnTitor Oct 20, 2026 •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This isn't true, it delegates to the underlying writer, which may overwrite earlier output. See the implementation, it calls self.buf.write_str(s) and buf is a mutable reference of an underlying writer.

View changes since the review

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update, please check!

@JohnTitor JohnTitor added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 20, 2026
@JohnTitor

Copy link
Copy Markdown
Member

@bors squash

@rust-bors

This comment has been minimized.

* doc: added addtional docs for Write

Signed-off-by: Gauravpawar101 <Gauravpawar2522@gmail.com>
* fix: correct docs for fmt write

Signed-off-by: Gauravpawar101 <Gauravpawar2522@gmail.com>
* doc: edit string.rs fmt docs
@rust-bors

rust-bors Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

🔨 3 commits were squashed into c58d7ba.

@rust-bors
rust-bors Bot force-pushed the fix/issue-164466 branch from e097c85 to c58d7ba Compare October 21, 2026 11:26

@JohnTitor JohnTitor left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rust-bors

rust-bors Bot commented Oct 21, 2026

Copy link
Copy Markdown
Contributor

📌 Commit c58d7ba has been tentatively approved by JohnTitor

It will be put into the queue for this repository once PR CI succeeds.

🌲 The tree is currently closed for pull requests below priority 5. This pull request will be tested once the tree is reopened.

Reason for tree closure: spurious failures

@rust-bors rust-bors Bot added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Oct 21, 2026
JonathanBrouwer added a commit to JonathanBrouwer/rust that referenced this pull request Oct 21, 2026
…=JohnTitor

doc: added addtional docs for Write

## Changes

- Added docs for `Write` with example.

Close rust-lang#164466
rust-bors Bot pushed a commit that referenced this pull request Oct 21, 2026
…uwer

Rollup of 13 pull requests

Successful merges:

 - #162460 (Feat - `#[inline(always)] + #[target_feature(enable = "....")]` #2)
 - #163485 (`rustc_builtin_macros` cleanup, part 8)
 - #164457 (Add `vec_visualizer` lldb test)
 - #161253 (Implement `AsMut<T>` and `AsRef<T>` for `!`.)
 - #162369 (Document the `recursion_limit` built-in attribute)
 - #162840 (tier 3 target policy: target CPU and features must be supported by upstream backend)
 - #164329 (use default_field_values in declare_lint)
 - #164330 (Skip redundant monomorphization checks)
 - #164527 (doc: added addtional docs for Write)
 - #164656 (stabilize ExitCodeExt for Windows)
 - #164660 (Touch up attribute docs)
 - #164681 (tidy: use repository-relative path for style checks)
 - #164688 (re-enable test_dir_remove_dir test on QNX)
@rust-bors
rust-bors Bot merged commit f4c0f63 into rust-lang:main Oct 21, 2026
14 checks passed
@rustbot rustbot added this to the 1.101.0 milestone Oct 21, 2026
rust-bors Bot pushed a commit that referenced this pull request Oct 21, 2026
Rollup merge of #164527 - GauravPawar101:fix/issue-164466, r=JohnTitor

doc: added addtional docs for Write

## Changes

- Added docs for `Write` with example.

Close #164466
@GauravPawar101
GauravPawar101 deleted the fix/issue-164466 branch October 22, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

std::fmt::Formatter write_fmt (append or replace ?)

3 participants