Skip to content

Several tests with //@ needs-force-clang-based-tests don't seem to run anywhere #126375

Open

Description

@Zalathar

(Follow-up to #126180 and #126257.)

There are currently 5 tests that use the needs-force-clang-based-tests header (formerly needs-matching-clang):

  • tests/run-make/cross-lang-lto-clang/Makefile (this one does actually run)
  • tests/run-make/cross-lang-lto-pgo-smoketest/Makefile
  • tests/run-make/cross-lang-lto-riscv-abi/rmake.rs
  • tests/run-make/issue-84395-lto-embed-bitcode/Makefile
  • tests/run-make/wasm-override-linker/Makefile

Tests with this header only run when RUSTBUILD_FORCE_CLANG_BASED_TESTS is set. That environment variable is only set in the x86_64-gnu-debug job, and only when running x --stage 2 test tests/run-make --test-args clang. So in practice, 4/5 of the above tests don't appear to ever run in any CI job.

@rustbot label +A-testsuite

Activity

  1. added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    A-testsuiteArea: The testsuite used to check the correctness of rustc
    on Jun 13, 2024
  2. Kobzol commented on Jun 13, 2024

    @Kobzol
    Member

    For completeness, this is the full list of run-make tests that are currently not being executed in any CI job, according to my CI scripts:

    [run-make] tests/run-make/cross-lang-lto-pgo-smoketest
    [run-make] tests/run-make/cross-lang-lto-riscv-abi
    [run-make] tests/run-make/issue-84395-lto-embed-bitcode
    [run-make] tests/run-make/wasm-exceptions-nostd
    [run-make] tests/run-make/wasm-override-linker
    [run-make] tests/run-make/windows-safeseh
    [run-make] tests/run-make/x86_64-fortanix-unknown-sgx-lvi
    
  3. added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    C-bugCategory: This is a bug.
    A-run-makeArea: port run-make Makefiles to rmake.rs
    and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-run-makeArea: port run-make Makefiles to rmake.rsA-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions