Skip to content

//@ needs-matching-clang is misleading #126180

Closed
Closed
//@ needs-matching-clang is misleading#126180
Labels
A-compiletestArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

Description

@Zalathar
Zalathar
opened on Jun 9, 2024

Via #126155, I discovered that the //@ needs-matching-clang compiletest header is a lot more strict than one might assume from its name.

Tests with this header are not run by default, regardless of whether a “matching clang” is available or not. Instead, they only run if environment variable RUSTBUILD_FORCE_CLANG_BASED_TESTS is set.

The only test job that sets this variable is x86_64-gnu-debug, but that job currently doesn't actually run any tests! (Though that might change as a result of #126155.)

@rustbot label +A-compiletest +A-testsuite

Activity

  1. rustbot
    added
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    A-compiletestArea: The compiletest test runner
    A-testsuiteArea: The testsuite used to check the correctness of rustc
    on Jun 9, 2024

  2. Zalathar commented on Jun 9, 2024

    @Zalathar
    Zalathar
    on Jun 9, 2024
    MemberAuthor

    For example, this might have caused the test added by #116264 to never actually run in CI.

  3. Zalathar
    changed the title [-]`needs-matching-clang` is misleading[/-] [+]`//@ needs-matching-clang` is misleading[/+] on Jun 9, 2024

  4. Zalathar commented on Jun 9, 2024

    @Zalathar
    Zalathar
    on Jun 9, 2024
    MemberAuthor

    Looks like there are a few tests that are broken, as a result of not actually being run in CI:

    #126155 (comment)

  5. jieyouxu
    added
    T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.
    T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.
    C-bugCategory: This is a bug.
    and removed
    needs-triageThis issue may need triage. Remove when done. See docs forge.rust-lang.org/release/issue-triaging
    on Jun 9, 2024
  6. jieyouxu
    added a commit that references this issue on Jun 11, 2024

    Rollup merge of rust-lang#126257 - Zalathar:needs-matching-clang, r=j…

    afce88e
  7. rust-timer
    added a commit that references this issue on Jun 11, 2024

    Unrolled build for rust-lang#126257

    9c65331

  8. Zalathar commented on Jun 13, 2024

    @Zalathar
    Zalathar
    on Jun 13, 2024
    MemberAuthor

    Mitigated by #126257; fixing the remaining tests can be tracked by #126375.

  9. Zalathar
    closed this as completedon Jun 13, 2024
  10. tgross35
    added a commit that references this issue on Jul 31, 2024

    Rollup merge of rust-lang#128356 - Oneirical:real-estate-reaLTOr, r=j…

    aadaa32
  11. matthiaskrgr
    added a commit that references this issue on Jul 31, 2024

    Rollup merge of rust-lang#128356 - Oneirical:real-estate-reaLTOr, r=j…

    5027004
  12. bors
    added 4 commits that reference this issue on Aug 1, 2024

    Auto merge of rust-lang#128356 - Oneirical:real-estate-reaLTOr, r=<try>

    fd45d9d

    Auto merge of rust-lang#128356 - Oneirical:real-estate-reaLTOr, r=<try>

    baf9765

    Auto merge of rust-lang#128356 - Oneirical:real-estate-reaLTOr, r=<try>

    37f4f81

    Auto merge of rust-lang#128356 - Oneirical:real-estate-reaLTOr, r=<try>

    6cf9310
  13. jieyouxu
    added 3 commits that reference this issue on Aug 2, 2024

    Rollup merge of rust-lang#128356 - Oneirical:real-estate-reaLTOr, r=j…

    bb8c58a

    Rollup merge of rust-lang#128356 - Oneirical:real-estate-reaLTOr, r=j…

    3eabc83

    Rollup merge of rust-lang#128356 - Oneirical:real-estate-reaLTOr, r=j…

    b3ebd3b
  14. bors
    added a commit that references this issue on Aug 3, 2024

    Auto merge of rust-lang#128356 - Oneirical:real-estate-reaLTOr, r=jie…

    a604303
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-compiletestArea: The compiletest test runnerA-testsuiteArea: The testsuite used to check the correctness of rustcC-bugCategory: This is a bug.T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.T-infraRelevant to the infrastructure team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions