regression: misaligned pointer dereference: address must be a multiple ... #111487

Activity

1. Mark-Simulacrum

   added

   regression-from-stable-to-betaPerformance or correctness regression from stable to beta.Performance or correctness regression from stable to beta.

   on May 12, 2023
2. rustbot

   added

   I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}Issue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}

   on May 12, 2023
3. Mark-Simulacrum

   added this to the 1.71.0 milestone on May 12, 2023
4. Mark-Simulacrum

   added

   T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.Relevant to the compiler team, which will review and decide on the PR/issue.

   T-libsRelevant to the library team, which will review and decide on the PR/issue.Relevant to the library team, which will review and decide on the PR/issue.

   on May 12, 2023
5. Mark-Simulacrum commented on May 12, 2023

   

   Mark-Simulacrum

   on May 12, 2023

   MemberAuthor

   More actions

   #98112 doesn't seem to have an FCP for doing this, which makes some sense (it's just "exploiting" UB).

   @saethlin did we file PRs against the relevant crates which break the most transitive tests at least? e.g., rand_core 0.2.x, 0.3.x, 0.4.x seem to be a good fraction of this list. There's a few more crates that seem to stand out too (e.g., plotters-bitmap).
6. saethlin commented on May 12, 2023

   

   saethlin

   on May 12, 2023

   Member

   More actions

   We did not make any effort to file fixes for the relevant crates.

   The rand_core issue in 0.4 has been patched for about 4 years: rust-random/rand#783 then it looks to me like rand does the semver trick, so I think they pulled the fix into 0.3 and 0.2, based on spot checking.

   The plotters-bitmap issue was patched a few weeks ago, it's just not released yet: plotters-rs/plotters#467
7. saethlin commented on May 12, 2023

   

   saethlin

   on May 12, 2023

   Member

   More actions

   The only things I think are significant are:

   An issue in an old version (almost 4 years old) of wasmtime-runtime, https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/rohankumardubey.wizer/log.txt

   Multiple crates hitting an issue in kamadak-exif-0.3.1:
   https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/reg/quad-image-0.1.1/log.txt
   https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/jondot.rawsort/log.txt
   https://crater-reports.s3.amazonaws.com/beta-1.70-2/beta-2023-05-08/gh/senden9.geo_fence/log.txt
   This issue was patched 4 years ago in kamadak/exif-rs@288a7e8 but there isn't a semver-compatible update available.

   I don't think these are worth doing anything with. All we could do here is ask maintainers to backport fixes.
8. Mark-Simulacrum commented on May 12, 2023

   

   Mark-Simulacrum

   on May 12, 2023

   MemberAuthor

   More actions

   Sounds like that's right. The main thing we usually try to ensure is that there is some upgrade path, especially for common code, and I think this covers most of that. Plus it technically won't affect non-debug builds, so users have that escape hatch too.

   I'm fine leaving this as-is.

   👍React with 👍2Reacted by Ben Kimock and scottmcm
9. Mark-Simulacrum

   modified the milestones: 1.71.0, 1.70.0 on May 13, 2023
10. Mark-Simulacrum

    removed

    I-prioritizeIssue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}Issue needs a team member to assess the impact. Will be replaced by P-{low,medium,high,critical}

    on May 13, 2023
11. bors

    added a commit that references this issue on May 28, 2023

    Auto merge of rust-lang#112026 - saethlin:misaligned-addrof, r=pnkfelix

    ...

    39c03fb
12. saethlin

    added a commit that references this issue on May 29, 2023

    Auto merge of #112026 - saethlin:misaligned-addrof, r=pnkfelix

    ...

    5de417c
13. oherrala commented on Jun 2, 2023

    

    oherrala

    on Jun 2, 2023

    More actions

    I think ipconfig crate is affected by this: liranringel/ipconfig#53

    thread '<redacted>' panicked at 'misaligned pointer dereference: address must be a multiple of 0x8 but is 0x189f604', C:\Users\runneradmin\.cargo\registry\src\index.crates.io-1cd66030c949c28d\ipconfig-0.3.1\src\adapter.rs:293:23
    
14. saethlin commented on Jun 2, 2023

    

    saethlin

    on Jun 2, 2023

    Member

    More actions

    @Mark-Simulacrum Should this issue stay open? I don't think we have an actual regression here.
15. Mark-Simulacrum

    closed this as completedon Jun 2, 2023
16. Mark-Simulacrum commented on Jun 2, 2023

    

    Mark-Simulacrum

    on Jun 2, 2023

    MemberAuthor

    More actions

    Yeah, I think we can close this.