Skip to content

Fix unaligned read/write in bitmap backend. - #467

Merged
AaronErhardt merged 5 commits into
plotters-rs:masterfrom
Berrysoft:fix/unaligned
Apr 20, 2023
Merged

AaronErhardt merged 5 commits into
plotters-rs:masterfrom
Berrysoft:fix/unaligned

Conversation

@Berrysoft

Copy link
Copy Markdown
Contributor

Fixes #461

@Berrysoft Berrysoft changed the title Fix unaligned write in bitmap backend. Fix unaligned read/write in bitmap backend. Apr 20, 2023
@nbdd0121

Copy link
Copy Markdown

Please fix the reliance on tuple layout as well (i.e. change (u64, u64, u64) to [u64; 3])

@AaronErhardt AaronErhardt left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you check whether the next-release-devel branch that's used for the upcoming version is also affected?

@AaronErhardt
AaronErhardt merged commit c34fcc0 into plotters-rs:master Apr 20, 2023
@Berrysoft
Berrysoft deleted the fix/unaligned branch April 20, 2023 19:40
@Berrysoft

Copy link
Copy Markdown
Contributor Author

@AaronErhardt yes, it is also affected.

@AaronErhardt

Copy link
Copy Markdown
Member

Would you mind sending a PR for that branch as well?

@Berrysoft

Copy link
Copy Markdown
Contributor Author

I've opened a PR: #469

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Panic in unsafe fill_rect_fast

3 participants