Repository navigation
Split matches - #8400
Split matches#8400
Conversation
|
r? @Manishearth (rust-highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
flip1995
left a comment
flip1995
left a comment
There was a problem hiding this comment.
All the current lint extractions LGTM. Thanks for splitting this up!
| match_wild_err_arm::check(cx, ex, arms); | ||
| match_wild_enum::check(cx, ex, arms); | ||
| match_as_ref::check(cx, ex, arms, expr); | ||
| check_wild_in_or_pats(cx, arms); |
There was a problem hiding this comment.
There are some lints left in mod.rs. I guess this is because the linting code is too small to extract them into their own file?
There was a problem hiding this comment.
I actually missed check_wild_in_or_pats. It's small enough it doesn't really matter though. The other two I just left because they were in different check functions. Could all be moved out though.
There was a problem hiding this comment.
Let's move them all out then. get the mod.rs file completely cleaned up, while you're at it 👍
|
☔ The latest upstream changes (presumably #8305) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@bors r+ amazing, thanks! |
|
📌 Commit c65894c has been approved by |
|
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
Part of #6680
changelog: None