[Jarcho]

fixes: #234
fixes: #8367
fixes: #8380

Still things to do:

• This currently only lints &*<expr> when it doesn't trigger needless_borrow.
• This requires a borrow after a deref to trigger. So *<expr> changing &&T to &T won't be caught.
• The deref and deref_mut trait methods aren't linted.
• Neither field accesses, nor method receivers are linted.
• This probably shouldn't lint reborrowing.
• Full slicing to deref should probably be handled here as well. e.g. &vec[..] when just &vec would do

changelog: new lint explicit_auto_deref

[rust-highfive]

r? @flip1995

(rust-highfive has picked a reviewer for you, use r? to override)

[bors]

☔ The latest upstream changes (presumably #8359) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

☔ The latest upstream changes (presumably #8289) made this pull request unmergeable. Please resolve the merge conflicts.

[djc]

Does this also fix this case?

pub fn put_u16(v: u16, out: &mut [u8]) {
    let out: &mut [u8; 2] = (&mut out[..2]).try_into().unwrap();
    *out = u16::to_be_bytes(v);
}

Warning:   --> rustls/src/msgs/codec.rs:91:29
   |
91 |     let out: &mut [u8; 2] = (&mut out[..2]).try_into().unwrap();
   |                             ^^^^^^^^^^^^^^^ help: change this to: `out[..2]`
   |
   = note: `#[warn(clippy::needless_borrow)]` on by default
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

[flip1995]

LGTM. r=me after rebase

[bors]

☔ The latest upstream changes (presumably #9007) made this pull request unmergeable. Please resolve the merge conflicts.

[bors]

☔ The latest upstream changes (presumably #8639) made this pull request unmergeable. Please resolve the merge conflicts.

[flip1995]

Oh no, another instance, where GitHub didn't show me a notification for a force push. @Jarcho please approve this PR yourself with bors r=flip1995 after you rebased (as long as there aren't any surprising changes).

[Jarcho]

@bors r=flip1995

[bors]

📌 Commit 5e2a2d3 has been approved by flip1995

[bors]

⌛ Testing commit 5e2a2d3 with merge a4130e1...

[bors]

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: flip1995
Pushing a4130e1 to master...