Skip to content

Better detect when a field can be moved from in while_let_on_iterator - #8221

Merged
bors merged 1 commit into
rust-lang:masterfrom
Jarcho:while_let_on_iterator_8113
Jan 5, 2022
Merged

bors merged 1 commit into
rust-lang:masterfrom
Jarcho:while_let_on_iterator_8113

Conversation

@Jarcho

@Jarcho Jarcho commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

fixes #8113

changelog: Better detect when a field can be moved from in while_let_on_iterator

@rust-highfive

Copy link
Copy Markdown

r? @llogiq

(rust-highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jan 4, 2022
@llogiq

llogiq commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

Nice improvement! Thank you! @bors r+

@bors

bors commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

📌 Commit ff58efb has been approved by llogiq

@bors

bors commented Jan 4, 2022

Copy link
Copy Markdown
Contributor

⌛ Testing commit ff58efb with merge f2ea5fb...

bors added a commit that referenced this pull request Jan 4, 2022
Better detect when a field can be moved from in `while_let_on_iterator`

fixes #8113

changelog: Better detect when a field can be moved from in `while_let_on_iterator`
@bors

bors commented Jan 5, 2022

Copy link
Copy Markdown
Contributor

💥 Test timed out

@llogiq

llogiq commented Jan 5, 2022

Copy link
Copy Markdown
Contributor

@bors retry

@bors

bors commented Jan 5, 2022

Copy link
Copy Markdown
Contributor

⌛ Testing commit ff58efb with merge 92048f4...

@bors

bors commented Jan 5, 2022

Copy link
Copy Markdown
Contributor

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing 92048f4 to master...

@bors
bors merged commit 92048f4 into rust-lang:master Jan 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-review Status: Awaiting review from the assignee but also interested parties

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incorrect suggestion in while_let_on_iterator if iterator cannot be moved

4 participants